Re: [vim/vim] textprop: wrong Tab size in a line with virtual text above it (PR #20901)

----==_mimepart_6a6e24bc6d703_e8116030547db
Content-Type: text/plain; charset="UTF-8"

h-east left a comment (vim/vim#20901)

@chrisbra 
The failing job here is not caused by this change: the "testgui" job also
fails on master, and it is flaky.  Of the last five runs on master three
failed:

    9.2.0894  ok
    9.2.0893  failed
    (doc)     ok
    9.2.0892  failed
    9.2.0891  failed

Two tests fail in that job:

    Test_aucmd_win_scroll_multibyte()  Expected 18 but got 17
    Test_winfixsize_positions()        a different window layout

The first one is mine, added in 9.2.0880.  It compares the topline, which is
one line off in the GUI.  Shall I send a PR that adds CheckNotGui to it?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/vim/vim/pull/20901#issuecomment-5152419075
You are receiving this because you are subscribed to this thread.

Message ID: <vim/vim/pull/20901/[email protected]>

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups "vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion visit https://groups.google.com/d/msgid/vim_dev/vim/vim/pull/20901/c5152419075%40github.com.

----==_mimepart_6a6e24bc6d703_e8116030547db
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div style=3D"display: flex; flex-wrap: wrap; white-space: pre-wrap; align-=
items: center; "><img height=3D"20" width=3D"20" style=3D"border-radius:50%=
; margin-right: 4px;" decoding=3D"async" src=3D"https://avatars.githubuserc=
ontent.com/u/518808" /><strong>h-east</strong> left a comment <a href=3D"ht=
tps://github.com/vim/vim/pull/20901#issuecomment-5152419075">(vim/vim#20901=
)</a></div>
<p dir=3D"auto"><a class=3D"user-mention notranslate" data-hovercard-type=
=3D"user" data-hovercard-url=3D"/users/chrisbra/hovercard" data-octo-click=
=3D"hovercard-link-click" data-octo-dimensions=3D"link_type:self" href=3D"h=
ttps://github.com/chrisbra">@chrisbra</a><br>
The failing job here is not caused by this change: the "testgui" job also<b=
r>
fails on master, and it is flaky.  Of the last five runs on master three<br=
>
failed:</p>
<pre class=3D"notranslate"><code class=3D"notranslate">9.2.0894  ok
9.2.0893  failed
(doc)     ok
9.2.0892  failed
9.2.0891  failed
</code></pre>
<p dir=3D"auto">Two tests fail in that job:</p>
<pre class=3D"notranslate"><code class=3D"notranslate">Test_aucmd_win_scrol=
l_multibyte()  Expected 18 but got 17
Test_winfixsize_positions()        a different window layout
</code></pre>
<p dir=3D"auto">The first one is mine, added in 9.2.0880.  It compares the =
topline, which is<br>
one line off in the GUI.  Shall I send a PR that adds CheckNotGui to it?</p=
>

<p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&mda=
sh;<br />Reply to this email directly, <a href=3D"https://github.com/vim/vi=
m/pull/20901#issuecomment-5152419075">view it on GitHub</a>, or <a href=3D"=
https://github.com/notifications/unsubscribe-auth/ACY5DGB3GLF73Z3LP23CA3D5H=
YODZAVCNFSNUABEKJSXA33TNF2G64TZHM2DAOJZG42DQMR3JFZXG5LFHM2TAMZTGIYDKMJZGOQX=
MAQ">unsubscribe</a>.<br />Triage notifications, keep track of coding agent=
 tasks and review pull requests on the go with GitHub Mobile for <a href=3D=
"https://github.com/notifications/mobile/ios/ACY5DGAPIBKLVS2YYIHIJUT5HYODZA=
5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMJVGI2DCOJQG422M4TFM=
FZW63VKON2WE43DOJUWEZLEUVSXMZLOOSVGM33PORSXEX3JN5ZQ">iOS</a> and <a href=3D=
"https://github.com/notifications/mobile/android/ACY5DGFCKJDNLOEYATIWSTL5HY=
ODZA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMJVGI2DCOJQG422M=
4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSXGM33PORSXEX3BNZSHE33JMQ">Android</a>.=
 Download it today!
<br />You are receiving this because you are subscribed to this thread.<img=
 src=3D"https://github.com/notifications/beacon/ACY5DGC4D766QZ4P3S2V3DT5HYO=
DZBFCNFSM6AAAAAC4URUEMCWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3=
TUL5UWJTYAAAAACMY3VUB2M4TFMFZW63VKON2WE43DOJUWEZLE.gif" height=3D"1" width=
=3D"1" alt=3D"" /><span style=3D"color: transparent; font-size: 0; display:=
 none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: =
0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span>&lt;vim/vi=
m/pull/20901/c5152419075</span><span>@</span><span>github</span><span>.</sp=
an><span>com&gt;</span></span></p>

<script type=3D"application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/vim/vim/pull/20901#issuecomment-5152419075",
"url": "https://github.com/vim/vim/pull/20901#issuecomment-5152419075",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>

<p></p>

-- <br />
-- <br />
You received this message from the &quot;vim_dev&quot; maillist.<br />
Do not top-post! Type your reply below the text you are replying to.<br />
For more information, visit <a href=3D"http://www.vim.org/maillist.php">htt=
p://www.vim.org/maillist.php</a><br />
<br />
--- <br />
You received this message because you are subscribed to the Google Groups &=
quot;vim_dev&quot; group.<br />
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to <a href=3D"mailto:[email protected]">vim_dev+uns=
[email protected]</a>.<br />
To view this discussion visit <a href=3D"https://groups.google.com/d/msgid/=
vim_dev/vim/vim/pull/20901/c5152419075%40github.com?utm_medium=3Demail&utm_=
source=3Dfooter">https://groups.google.com/d/msgid/vim_dev/vim/vim/pull/209=
01/c5152419075%40github.com</a>.<br />

----==_mimepart_6a6e24bc6d703_e8116030547db--