Re: [vim/vim] Fix concealed text wrapping at conceallevel 3 (PR #20472)

----==_mimepart_6a6e9c6460570_ba1160256551a
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

pappasam left a comment (vim/vim#20472)

Additionally, I extracted the unrelated MS-Windows temporary-file change in=
to #20915. While that change was still present here, the Linux GUI job happ=
ened to pass; after extracting it, the same job failed twice in `Test_aucmd=
_win_scroll_multibyte()`.

This is a timing correlation rather than a functional dependency. On Unix, =
`vim_tempname()` uses a process-private temporary directory and ignores its=
 `keep` argument. The corresponding job for #20915 reached this test approx=
imately 170 ms after starting gVim, while the two failing runs here reached=
 it after approximately 147=E2=80=93151 ms.

The test=E2=80=99s underlying GUI resize race is independently reproduced a=
nd addressed by #20913: GTK may apply a pending shell resize between the tw=
o topline measurements. That PR changes the test to use a fixed-size window=
.

--=20
Reply to this email directly or view it on GitHub:
https://github.com/vim/vim/pull/20472#issuecomment-5154409027
You are receiving this because you are subscribed to this thread.

Message ID: <vim/vim/pull/20472/[email protected]>

--=20
--=20
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

---=20
You received this message because you are subscribed to the Google Groups "=
vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to [email protected].
To view this discussion visit https://groups.google.com/d/msgid/vim_dev/vim=
/vim/pull/20472/c5154409027%40github.com.

----==_mimepart_6a6e9c6460570_ba1160256551a
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div style=3D"display: flex; flex-wrap: wrap; white-space: pre-wrap; align-=
items: center; "><img height=3D"20" width=3D"20" style=3D"border-radius:50%=
; margin-right: 4px;" decoding=3D"async" src=3D"https://avatars.githubuserc=
ontent.com/u/3723671" /><strong>pappasam</strong> left a comment <a href=3D=
"https://github.com/vim/vim/pull/20472#issuecomment-5154409027">(vim/vim#20=
472)</a></div>
<p dir=3D"auto">Additionally, I extracted the unrelated MS-Windows temporar=
y-file change into <a class=3D"issue-link js-issue-link" data-error-text=3D=
"Failed to load title" data-id=3D"5038938419" data-permission-text=3D"Title=
 is private" data-url=3D"https://github.com/vim/vim/issues/20915" data-hove=
rcard-type=3D"pull_request" data-hovercard-url=3D"/vim/vim/pull/20915/hover=
card" href=3D"https://github.com/vim/vim/pull/20915">#20915</a>. While that=
 change was still present here, the Linux GUI job happened to pass; after e=
xtracting it, the same job failed twice in <code class=3D"notranslate">Test=
_aucmd_win_scroll_multibyte()</code>.</p>
<p dir=3D"auto">This is a timing correlation rather than a functional depen=
dency. On Unix, <code class=3D"notranslate">vim_tempname()</code> uses a pr=
ocess-private temporary directory and ignores its <code class=3D"notranslat=
e">keep</code> argument. The corresponding job for <a class=3D"issue-link j=
s-issue-link" data-error-text=3D"Failed to load title" data-id=3D"503893841=
9" data-permission-text=3D"Title is private" data-url=3D"https://github.com=
/vim/vim/issues/20915" data-hovercard-type=3D"pull_request" data-hovercard-=
url=3D"/vim/vim/pull/20915/hovercard" href=3D"https://github.com/vim/vim/pu=
ll/20915">#20915</a> reached this test approximately 170 ms after starting =
gVim, while the two failing runs here reached it after approximately 147=E2=
=80=93151 ms.</p>
<p dir=3D"auto">The test=E2=80=99s underlying GUI resize race is independen=
tly reproduced and addressed by <a class=3D"issue-link js-issue-link" data-=
error-text=3D"Failed to load title" data-id=3D"5038086941" data-permission-=
text=3D"Title is private" data-url=3D"https://github.com/vim/vim/issues/209=
13" data-hovercard-type=3D"pull_request" data-hovercard-url=3D"/vim/vim/pul=
l/20913/hovercard" href=3D"https://github.com/vim/vim/pull/20913">#20913</a=
>: GTK may apply a pending shell resize between the two topline measurement=
s. That PR changes the test to use a fixed-size window.</p>

<p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&mda=
sh;<br />Reply to this email directly, <a href=3D"https://github.com/vim/vi=
m/pull/20472#issuecomment-5154409027">view it on GitHub</a>, or <a href=3D"=
https://github.com/notifications/unsubscribe-auth/ACY5DGBJCEFDY6LWSQDVOB35H=
2J6JAVCNFSNUABEKJSXA33TNF2G64TZHM2DAOJZG42DQMR3JFZXG5LFHM2DMMZSGIZDSNRVG2QX=
MAQ">unsubscribe</a>.<br />Triage notifications, keep track of coding agent=
 tasks and review pull requests on the go with GitHub Mobile for <a href=3D=
"https://github.com/notifications/mobile/ios/ACY5DGGGLZAJXQFPATTQQ7L5H2J6JA=
5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMJVGQ2DAOJQGI32M4TFM=
FZW63VKON2WE43DOJUWEZLEUVSXMZLOOSVGM33PORSXEX3JN5ZQ">iOS</a> and <a href=3D=
"https://github.com/notifications/mobile/android/ACY5DGBIR46LXKCSW34VKYL5H2=
J6JA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMJVGQ2DAOJQGI32M=
4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSXGM33PORSXEX3BNZSHE33JMQ">Android</a>.=
 Download it today!
<br />You are receiving this because you are subscribed to this thread.<img=
 src=3D"https://github.com/notifications/beacon/ACY5DGHJOYMQ3FVRYNEPG6T5H2J=
6JBFCNFSM6AAAAAC2C3EKE2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3=
TUL5UWJTYAAAAACMZ2BJB2M4TFMFZW63VKON2WE43DOJUWEZLE.gif" height=3D"1" width=
=3D"1" alt=3D"" /><span style=3D"color: transparent; font-size: 0; display:=
 none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: =
0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span>&lt;vim/vi=
m/pull/20472/c5154409027</span><span>@</span><span>github</span><span>.</sp=
an><span>com&gt;</span></span></p>

<script type=3D"application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/vim/vim/pull/20472#issuecomment-5154409027",
"url": "https://github.com/vim/vim/pull/20472#issuecomment-5154409027",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>

<p></p>

-- <br />
-- <br />
You received this message from the &quot;vim_dev&quot; maillist.<br />
Do not top-post! Type your reply below the text you are replying to.<br />
For more information, visit <a href=3D"http://www.vim.org/maillist.php">htt=
p://www.vim.org/maillist.php</a><br />
<br />
--- <br />
You received this message because you are subscribed to the Google Groups &=
quot;vim_dev&quot; group.<br />
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to <a href=3D"mailto:[email protected]">vim_dev+uns=
[email protected]</a>.<br />
To view this discussion visit <a href=3D"https://groups.google.com/d/msgid/=
vim_dev/vim/vim/pull/20472/c5154409027%40github.com?utm_medium=3Demail&utm_=
source=3Dfooter">https://groups.google.com/d/msgid/vim_dev/vim/vim/pull/204=
72/c5154409027%40github.com</a>.<br />

----==_mimepart_6a6e9c6460570_ba1160256551a--