Re: [vim/vim] popup image: fix layering of overlapping images, avoid kitty retransmission on redraw (PR #20474)

----==_mimepart_6a7172d3ebcf9_d51180532223
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

64-bitman left a comment (vim/vim#20474)

> Thanks, you're right. This PR removes the retransmission on cursor moveme=
nt, but scrolling still re-encodes because the crop changes. The proper fix=
 is the transmit/place split you mention (`a=3Dt` to store the image once, =
`a=3Dp` with a source rectangle to draw the cropped region without resendin=
g the pixels). Since that's a larger change to the kitty encoder, I'd like =
to land this PR first and handle it in a follow-up.

@mattn Are you still working on this change? If not, I can try working on i=
t. Thanks

--=20
Reply to this email directly or view it on GitHub:
https://github.com/vim/vim/pull/20474#issuecomment-5174823838
You are receiving this because you are subscribed to this thread.

Message ID: <vim/vim/pull/20474/[email protected]>

--=20
--=20
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

---=20
You received this message because you are subscribed to the Google Groups "=
vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to [email protected].
To view this discussion visit https://groups.google.com/d/msgid/vim_dev/vim=
/vim/pull/20474/c5174823838%40github.com.

----==_mimepart_6a7172d3ebcf9_d51180532223
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div style=3D"display: flex; flex-wrap: wrap; white-space: pre-wrap; align-=
items: center; "><img height=3D"20" width=3D"20" style=3D"border-radius:50%=
; margin-right: 4px;" decoding=3D"async" src=3D"https://avatars.githubuserc=
ontent.com/u/60551350" /><strong>64-bitman</strong> left a comment <a href=
=3D"https://github.com/vim/vim/pull/20474#issuecomment-5174823838">(vim/vim=
#20474)</a></div>
<blockquote>
<p dir=3D"auto">Thanks, you're right. This PR removes the retransmission on=
 cursor movement, but scrolling still re-encodes because the crop changes. =
The proper fix is the transmit/place split you mention (<code class=3D"notr=
anslate">a=3Dt</code> to store the image once, <code class=3D"notranslate">=
a=3Dp</code> with a source rectangle to draw the cropped region without res=
ending the pixels). Since that's a larger change to the kitty encoder, I'd =
like to land this PR first and handle it in a follow-up.</p>
</blockquote>
<p dir=3D"auto"><a class=3D"user-mention notranslate" data-hovercard-type=
=3D"user" data-hovercard-url=3D"/users/mattn/hovercard" data-octo-click=3D"=
hovercard-link-click" data-octo-dimensions=3D"link_type:self" href=3D"https=
://github.com/mattn">@mattn</a> Are you still working on this change? If no=
t, I can try working on it. Thanks</p>

<p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&mda=
sh;<br />Reply to this email directly, <a href=3D"https://github.com/vim/vi=
m/pull/20474#issuecomment-5174823838">view it on GitHub</a>, or <a href=3D"=
https://github.com/notifications/unsubscribe-auth/ACY5DGGJS3D4DN6EPXFDKAL5I=
FVFHAVCNFSNUABEKJSXA33TNF2G64TZHM2DAOJZG42DQMR3JFZXG5LFHM2DMMZSHA2DMNZZHGQX=
MAQ">unsubscribe</a>.<br />Triage notifications, keep track of coding agent=
 tasks and review pull requests on the go with GitHub Mobile for <a href=3D=
"https://github.com/notifications/mobile/ios/ACY5DGBLYBOG4GJFXITB2ID5IFVFHA=
5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMJXGQ4DEMZYGM4KM4TFM=
FZW63VKON2WE43DOJUWEZLEUVSXMZLOOSVGM33PORSXEX3JN5ZQ">iOS</a> and <a href=3D=
"https://github.com/notifications/mobile/android/ACY5DGHHJXYT34ZROCBJH4T5IF=
VFHA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMJXGQ4DEMZYGM4KM=
4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSXGM33PORSXEX3BNZSHE33JMQ">Android</a>.=
 Download it today!
<br />You are receiving this because you are subscribed to this thread.<img=
 src=3D"https://github.com/notifications/beacon/ACY5DGAEBGTO7BC6X763VGD5IFV=
FHBFCNFSM6AAAAAC2C7PKVOWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3=
TUL5UWJTYAAAAACNDRROPKM4TFMFZW63VKON2WE43DOJUWEZLE.gif" height=3D"1" width=
=3D"1" alt=3D"" /><span style=3D"color: transparent; font-size: 0; display:=
 none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: =
0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span>&lt;vim/vi=
m/pull/20474/c5174823838</span><span>@</span><span>github</span><span>.</sp=
an><span>com&gt;</span></span></p>

<script type=3D"application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/vim/vim/pull/20474#issuecomment-5174823838",
"url": "https://github.com/vim/vim/pull/20474#issuecomment-5174823838",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>

<p></p>

-- <br />
-- <br />
You received this message from the &quot;vim_dev&quot; maillist.<br />
Do not top-post! Type your reply below the text you are replying to.<br />
For more information, visit <a href=3D"http://www.vim.org/maillist.php">htt=
p://www.vim.org/maillist.php</a><br />
<br />
--- <br />
You received this message because you are subscribed to the Google Groups &=
quot;vim_dev&quot; group.<br />
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to <a href=3D"mailto:[email protected]">vim_dev+uns=
[email protected]</a>.<br />
To view this discussion visit <a href=3D"https://groups.google.com/d/msgid/=
vim_dev/vim/vim/pull/20474/c5174823838%40github.com?utm_medium=3Demail&utm_=
source=3Dfooter">https://groups.google.com/d/msgid/vim_dev/vim/vim/pull/204=
74/c5174823838%40github.com</a>.<br />

----==_mimepart_6a7172d3ebcf9_d51180532223--