[vim/vim] hardcopy: prototypes are hand-written instead of generated (after 9.2.0898) (PR #20946)
h_east (Vim Github Repository) <[email protected]> Tue, 04 Aug 2026 23:07:03 -0700
| Newsgroups | gmane.editors.vim.devel |
|---|---|
| Message-ID | <vim/vim/pull/[email protected]> |
----==_mimepart_6a72d307b3948_b8118065785a
Content-Type: text/plain; charset="UTF-8"
```
Problem: The prototypes for the pango and PostScript hardcopy functions
are written by hand in hardcopy_pango.h and
hardcopy_postscript.h, instead of being generated into proto/
like for every other source file.
Solution: Generate proto/hardcopy_pango.pro and
proto/hardcopy_postscript.pro, include them from proto.h and
drop the hand-written declarations. hardcopy_pango.h only held
prototypes and is removed; hardcopy_postscript.h keeps its
defines and the mbfont_opts declaration.
```
(Cc: @64-bitman )
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/20946
-- Commit Summary --
* hardcopy: prototypes are hand-written instead of generated
-- File Changes --
M Filelist (3)
M src/Makefile (8)
M src/hardcopy.c (3)
M src/hardcopy_pango.c (1)
M src/hardcopy_postscript.h (13)
M src/proto.h (6)
R src/proto/hardcopy_pango.pro (22)
A src/proto/hardcopy_postscript.pro (14)
-- Patch Links --
https://github.com/vim/vim/pull/20946.patch
https://github.com/vim/vim/pull/20946.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/vim/vim/pull/20946
You are receiving this because you are subscribed to this thread.
Message ID: <vim/vim/pull/[email protected]>
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups "vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion visit https://groups.google.com/d/msgid/vim_dev/vim/vim/pull/20946%40github.com.
----==_mimepart_6a72d307b3948_b8118065785a
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
<pre class=3D"notranslate"><code class=3D"notranslate">Problem: The protot=
ypes for the pango and PostScript hardcopy functions
are written by hand in hardcopy_pango.h and
hardcopy_postscript.h, instead of being generated into proto/
like for every other source file.
Solution: Generate proto/hardcopy_pango.pro and
proto/hardcopy_postscript.pro, include them from proto.h and
drop the hand-written declarations. hardcopy_pango.h only held
prototypes and is removed; hardcopy_postscript.h keeps its
defines and the mbfont_opts declaration.
</code></pre>
<p dir=3D"auto">(Cc: <a class=3D"user-mention notranslate" data-hovercard-t=
ype=3D"user" data-hovercard-url=3D"/users/64-bitman/hovercard" data-octo-cl=
ick=3D"hovercard-link-click" data-octo-dimensions=3D"link_type:self" href=
=3D"https://github.com/64-bitman">@64-bitman</a> )</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href=3D'https://github.com/vim/vim/pull/20946'>https://gi=
thub.com/vim/vim/pull/20946</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href=3D"https://github.com/vim/vim/pull/20946/commits/d48b9b5754b2=
d8a18e3e1b1c3b7a6ffbb35547e1" class=3D"commit-link">d48b9b5</a> hardcopy: =
prototypes are hand-written instead of generated</li>
</ul>
<h4 style=3D"display: inline-block">File Changes </h4> <p style=3D"display:=
inline-block">(<a href=3D"https://github.com/vim/vim/pull/20946/files">8&n=
bsp;files</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href=3D"https://github.com/vim/vim/pull/20946/files#diff-fd11e52eab6=
2dcc4bbac152c451df8ec45a90046b0d2a22e79fe123a617de193">Filelist</a>
(3)
</li>
<li>
<strong>M</strong>
<a href=3D"https://github.com/vim/vim/pull/20946/files#diff-3e2513390df=
543315686d7c85bd901ca9256268970032298815d2f893a9f0685">src/Makefile</a>
(8)
</li>
<li>
<strong>M</strong>
<a href=3D"https://github.com/vim/vim/pull/20946/files#diff-082d681f725=
b22d30b7bb977de22619413cf9c94ef6860658994f885ea575286">src/hardcopy.c</a>
(3)
</li>
<li>
<strong>M</strong>
<a href=3D"https://github.com/vim/vim/pull/20946/files#diff-0c1bea333af=
f8db4b22c4d7722a85de3ca0552786ccc230170d786f755280bbb">src/hardcopy_pango.c=
</a>
(1)
</li>
<li>
<strong>M</strong>
<a href=3D"https://github.com/vim/vim/pull/20946/files#diff-87c475f1f31=
692d43e786259dc072f9c2b865a9be64b37c9f9359d24ff69168a">src/hardcopy_postscr=
ipt.h</a>
(13)
</li>
<li>
<strong>M</strong>
<a href=3D"https://github.com/vim/vim/pull/20946/files#diff-a5479c601d5=
3d8cd6adc8fa5afa091deedd27ae5a53132d32b4c8cc27b60af6c">src/proto.h</a>
(6)
</li>
<li>
<strong>R</strong>
<a href=3D"https://github.com/vim/vim/pull/20946/files#diff-696bf5b4fb0=
e40ad7a48a912050846072b55c826d79eb661b06a10f7e29ee37f">src/proto/hardcopy_p=
ango.pro</a>
(22)
</li>
<li>
<strong>A</strong>
<a href=3D"https://github.com/vim/vim/pull/20946/files#diff-80094ba0ef7=
accce7bbc56d622976de0e4189f918d5b8ed7692fdd9780900696">src/proto/hardcopy_p=
ostscript.pro</a>
(14)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href=3D'https://github.com/vim/vim/pull/20946.patch'>https://githu=
b.com/vim/vim/pull/20946.patch</a></li>
<li><a href=3D'https://github.com/vim/vim/pull/20946.diff'>https://github=
.com/vim/vim/pull/20946.diff</a></li>
</ul>
<p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&mda=
sh;<br />Reply to this email directly, <a href=3D"https://github.com/vim/vi=
m/pull/20946">view it on GitHub</a>, or <a href=3D"https://github.com/notif=
ications/unsubscribe-auth/ACY5DGFGG5E2Z6OBDW6LJY35ILFIPAVCNFSNUABEKJSXA33TN=
F2G64TZHM2DAOJZG42DQMR3JFZXG5LFHM2TANRXHA4DAMRUGCQXMAQ">unsubscribe</a>.<br=
/>Triage notifications, keep track of coding agent tasks and review pull r=
equests on the go with GitHub Mobile for <a href=3D"https://github.com/noti=
fications/mobile/ios/ACY5DGGVZQKZKJZR2K4WI4D5ILFIPA5CNFSNUABEM5UWIORPF5TWS5=
BNNB2WEL2QOVWGYUTFOF2WK43UF42DEMBZGYZDCMRYHGTHEZLBONXW5KTTOVRHGY3SNFRGKZFFM=
V3GK3TUVJTG633UMVZF62LPOM">iOS</a> and <a href=3D"https://github.com/notifi=
cations/mobile/android/ACY5DGCWEJZONLLZ5LWDKT35ILFIPA5CNFSNUABEM5UWIORPF5TW=
S5BNNB2WEL2QOVWGYUTFOF2WK43UF42DEMBZGYZDCMRYHGTHEZLBONXW5KTTOVRHGY3SNFRGKZF=
FMV3GK3TUVZTG633UMVZF6YLOMRZG62LE">Android</a>. Download it today!
<br />You are receiving this because you are subscribed to this thread.<img=
src=3D"https://github.com/notifications/beacon/ACY5DGD4NQLOJ6L7YXDDZTT5ILF=
IPBFCNFSM6AAAAAC44BDIHGWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHQAA=
AAAEXBDNZQUZZGKYLTN5XKU43VMJZWG4TJMJSWI.gif" height=3D"1" width=3D"1" alt=
=3D"" /><span style=3D"color: transparent; font-size: 0; display: none; vis=
ibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-wid=
th: 0; max-height: 0; mso-hide: all">Message ID: <span><vim/vim/pull/209=
46</span><span>@</span><span>github</span><span>.</span><span>com></span=
></span></p>
<script type=3D"application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/vim/vim/pull/20946",
"url": "https://github.com/vim/vim/pull/20946",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
<p></p>
-- <br />
-- <br />
You received this message from the "vim_dev" maillist.<br />
Do not top-post! Type your reply below the text you are replying to.<br />
For more information, visit <a href=3D"http://www.vim.org/maillist.php">htt=
p://www.vim.org/maillist.php</a><br />
<br />
--- <br />
You received this message because you are subscribed to the Google Groups &=
quot;vim_dev" group.<br />
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to <a href=3D"mailto:[email protected]">vim_dev+uns=
[email protected]</a>.<br />
To view this discussion visit <a href=3D"https://groups.google.com/d/msgid/=
vim_dev/vim/vim/pull/20946%40github.com?utm_medium=3Demail&utm_source=3Dfoo=
ter">https://groups.google.com/d/msgid/vim_dev/vim/vim/pull/20946%40github.=
com</a>.<br />
----==_mimepart_6a72d307b3948_b8118065785a--