Commit: patch 9.2.0915: tests: two terminal tests in test_popupwin fail on FreeBSD
Christian Brabandt <[email protected]> Thu, 6 Aug 2026 20:45:06 +0200
| Newsgroups | gmane.editors.vim.devel |
|---|---|
| Message-ID | <[email protected]> |
patch 9.2.0915: tests: two terminal tests in test_popupwin fail on FreeBSD Commit: https://github.com/vim/vim/commit/bd127c602deb480dd9fc7007e8e5a50897646122 Author: Hirohito Higashi <[email protected]> Date: Wed Aug 5 19:29:01 2026 +0000 patch 9.2.0915: tests: two terminal tests in test_popupwin fail on FreeBSD Problem: Two terminal tests in test_popupwin fail on FreeBSD, where the shell echoes the typed character more than once (neil). Solution: Only assert the start of the terminal line. fixes: #20955 closes: #20957 Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Signed-off-by: Hirohito Higashi <[email protected]> Signed-off-by: Christian Brabandt <[email protected]> diff --git a/src/testdir/test_popupwin.vim b/src/testdir/test_popupwin.vim index 682673109..61af5e050 100644 --- a/src/testdir/test_popupwin.vim +++ b/src/testdir/test_popupwin.vim @@ -3076,11 +3076,12 @@ func Test_popupwin_terminal_buffer() call WaitForAssert({-> assert_equal("run", job_status(term_getjob(termbuf)))}) call WaitForAssert({-> assert_equal('', term_getline(termbuf, '.'))}) - " When typing a character, the cursor is after it. + " When typing a character, the cursor is after it. Some shells echo it + " more than once. call feedkeys("x", 'xt') call term_wait(termbuf) redraw - call WaitForAssert({-> assert_equal('x', term_getline(termbuf, '.'))}) + call WaitForAssert({-> assert_match('^x', term_getline(termbuf, '.'))}) call feedkeys("\<BS>", 'xt') " Check this doesn't crash @@ -5480,10 +5481,11 @@ func Test_popup_opacity_terminal_no_freeze() " Before the fix typing froze Vim: redraw under an opacity popup raised " must_redraw every cycle, trapping terminal_loop in its redraw loop. + " Some shells echo the character more than once. call feedkeys('x', 'xt') call term_wait(termbuf) redraw - call WaitForAssert({-> assert_equal('x', term_getline(termbuf, '.'))}) + call WaitForAssert({-> assert_match('^x', term_getline(termbuf, '.'))}) call feedkeys("\<BS>", 'xt') call feedkeys("exit\<CR>", 'xt') diff --git a/src/version.c b/src/version.c index 1931bc906..cca2e3afa 100644 --- a/src/version.c +++ b/src/version.c @@ -763,6 +763,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ +/**/ + 915, /**/ 914, /**/ -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion visit https://groups.google.com/d/msgid/vim_dev/E1ws35W-00GSME-O5%40256bit.org.