Re: [vim/vim] Fix :set pumopt and :set pumborder command-line completion (PR #20910)

shaneharper left a comment (vim/vim#20910)

I have addressed the review comments from 2 August. Most notably, for command-line completion of both :set pumopt and :set pumborder, the "single", "double" and "round" border styles are no longer offered when they can't be used.

I was required to remove the "indentation" from:
`# define completing_value_for_subopt(args, name) \`
to get the codestyle check to pass.

(I had not forgotten about [#20676 (comment)](https://github.com/vim/vim/pull/20676#issuecomment-4844854787). Before #20893, I'd intended to include it as a separate commit in this PR, since both relate to sub-option completion.)


-- 
Reply to this email directly or view it on GitHub:
https://github.com/vim/vim/pull/20910#issuecomment-5239788880
You are receiving this because you are subscribed to this thread.

Message ID: <vim/vim/pull/20910/[email protected]>

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups "vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion visit https://groups.google.com/d/msgid/vim_dev/vim/vim/pull/20910/c5239788880%40github.com.