Re: [vim/vim] Implement popup image feature using Kitty graphics protocol properly (PR #21018)
Christian Brabandt (Vim Github Repository) <[email protected]>
| Newsgroups | gmane.editors.vim.devel |
|---|---|
| Message-ID | <vim/vim/pull/21018/[email protected]> |
chrisbra left a comment (vim/vim#21018) > Sorry, what do you mean by this? Did :echo base64_encode(0z010002) behave wrong before this PR? It adds padding at the wrong position: ``` :echo base64_encode(0z010002) AQ=C :call writefile(0z010002, '/tmp/blob') :!openssl base64 < /tmp/blob AQAC ``` So I suggest to factor out the base64 related changes to a separate commit which includes a test for this. Thanks, -- Reply to this email directly or view it on GitHub: https://github.com/vim/vim/pull/21018#issuecomment-5289938495 You are receiving this because you are subscribed to this thread. Message ID: <vim/vim/pull/21018/[email protected]> -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion visit https://groups.google.com/d/msgid/vim_dev/vim/vim/pull/21018/c5289938495%40github.com.