Re: [vim/vim] patch 9.2.XXXX: multiline dictionaries in :command and :autocmd cause E488 (PR #21073)

Amariah Abishai (Vim Github Repository) <[email protected]>
Newsgroups gmane.editors.vim.devel
Message-ID <vim/vim/pull/21073/[email protected]>
AmariahAK left a comment (vim/vim#21073)

@h-east 
Thanks for the detailed review. I addressed the distinction between command blocks and dictionary expression continuation.

Actual command blocks continue to use find_cmd_block_start(). Dictionary arguments now use a separate predicate and are collected with brace-depth tracking, so nested dictionaries and list-of-dictionaries are handled without restoring the previous broad behavior that incorrectly treated normal!

The opener detection now trims trailing whitespace, accepts [, and uses vim_strchr(). The tests define and execute Bar(), then verify the collected dictionary contents, including nested values. The src/version.c change was also removed from the patch.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/vim/vim/pull/21073#issuecomment-5318130676
You are receiving this because you are subscribed to this thread.

Message ID: <vim/vim/pull/21073/[email protected]>

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups "vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion visit https://groups.google.com/d/msgid/vim_dev/vim/vim/pull/21073/c5318130676%40github.com.
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.