Re: [vim/vim] completion list is miss sorted after complete() (PR #21103)
Christian Brabandt (Vim Github Repository) <[email protected]>
| Newsgroups | gmane.editors.vim.devel |
|---|---|
| Message-ID | <vim/vim/pull/21103/[email protected]> |
chrisbra left a comment (vim/vim#21103) Thanks, I see the test currently fails, so changing the if condition is probably right. However, I am slightly worried about the new else case. It doesn't cut off the leader anymore (as the function comment claims) and there does not seem to be a test for this. And finally I'd say the test should not leave out the first byte of the line but compare the whole line directly. So I don't think this is ready yet. -- Reply to this email directly or view it on GitHub: https://github.com/vim/vim/pull/21103#issuecomment-5359913706 You are receiving this because you are subscribed to this thread. Message ID: <vim/vim/pull/21103/[email protected]> -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion visit https://groups.google.com/d/msgid/vim_dev/vim/vim/pull/21103/c5359913706%40github.com.