Re: [Brett Presnell] Re: Fedora Core 3: File mode specification error

* David Kastrup (2005-01-20) writes:

> Ralf Angeli <[email protected]> writes:
>
>> A proposed patch is attached.  Yes, it looks ugly, but still better
>> than let-binding another set of variables.
>
> How about (let ((this (append whatever bla))
>                 (that (append blubb blah)))
>              (setq this (and this (regexp-opt this))
>                    that (and that (regexp-opt that)))
>
> Of course, this depends on nil being a valid value for this and that.
>
> If not, we need
>
> (setq this (if this (regexp-opt this) "")
>       that (if that (regexp-opt that) ""))

`this' is used only if `(length this)' returns something greater than
zero and `(length nil)' returns zero in the Emacsen I have here.

> That needs no additional let-binding.  On the other hand, it also does
> not appear much of an improvement.

It is less "abundant" then my stab at it.  I checked in a change
corresponding to your suggestion.

-- 
Ralf