Re: Issues with japanese support

Ralf Angeli <[email protected]>
Newsgroups gmane.emacs.auc-tex
Message-ID <[email protected]>
* Masayuki Ataka (2005-03-02) writes:

>> > Ikumi's question is `What for this fill-space text property is set?'
>> > If this property is not used, it is something like a garbage.
>> 
>> Argh, when looking at what Emacs 21 does, I forgot that we actually
>> set the property in other compatibility code.  If you think that
>> checking for the property in `LaTeX-fill-delete-newlines' is useful,
>> please add the code from `fill-delete-newlines' I left out.
>
> In CVS Emacs, 'fill-space is used for checking double space
> after period, using variable `sentence-end-without-space', which
> is not available in Emacs 21.4.

Hm, I don't see such a connection.  AFAICS
`sentence-end-without-space' is only used for adding extra spaces to
sentence endings at the end of a line before the newlines will get
removed in `fill-delete-newlines'.

The 'fill-space property in contrast is used, i.e. checked, during the
loop deleting newlines.  Because such properties may be added by
`LaTeX-fill-newline' I think it could indeed be useful to check for
them in `LaTeX-fill-delete-newlines'.

>> The code setting the text property in `LaTeX-fill-newline' should not
>> be removed because the text property is checked in
>> `fill-delete-newlines' and therefore is useful in Emacs 22 (the
>
> Okay.
> This is another suggestion from Ikumi:
>    Do not set 'fill-space if Emacs < 22.1.
>
> It seems good to me.

In such cases it is always better to check for a feature instead of a
version number.  But as explained above it should not be necessary to
wrap that code in a condition if we add code to check for the
'fill-space text property in `LaTeX-fill-delete-newlines'.

>> upcoming release).
>> 
> Really? Xp

Well, I just wanted to be clear.  Who knows what version number we
will end up with. (^-^)b

-- 
Ralf
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.