Re: [PATCH] Silencing the compiler with latest Emacs master

Roland Winkler <[email protected]> Sun, 10 Jul 2022 22:57:17 -0500
Newsgroups gmane.emacs.bbdb.user
Message-ID <[email protected]>
On Wed, Jul 06 2022, Arash Esbati wrote:
> Thanks.  But I was too optimistic about fixing them all.  Please find
> attached a patch fixing 2 docstring issues reported by the compiler.

It seems you are updating your emacs from trunk more often than me.
Even before installing your first patch I could compile BBDB without
complaints of the compiler and I expect your first patch covered all
complaints of the then latest compiler when you prepared this patch.

So I guess we can play this game more frequently  :-)

> Further, the compiler complains about:
>
>   bbdb.el:1736:29: Warning: =E2=80=98sc-load-hook=E2=80=99 is an obsolete=
 variable (as of 26.1);
>       use =E2=80=98with-eval-after-load=E2=80=99 instead.
>
> I'm also attaching a small change using `eval-after-load' which should
> fix this and also supports older Emacs'en.

Funny!  Emacs 27 and 28 compile this code without complaints.
But I'll be glad when these load hooks disappear.