bug#81408: 31.0.90; gnus-icalendar-event--find-attendee no longer matches regexp quoted strings

Morgan Willcock <[email protected]> writes:

>> Richard Lawrence <[email protected]> writes:
>> In any case, here's an updated patch that restores this old behavior, as
>> far as I can tell...
>
> The patch appears to work - with it applied the accept/decline buttons
> on meetings now indicate that an identity was matched.

OK, great.

>> If there's a logic to this, please enlighten me!  Otherwise it seems
>> like this is really crying out for cleanup.  What would *actually* make
>> sense here, and as a return value for `gnus-icalendar-identities'?
>
> It is probably more important to just restore the previous behavior for
> the moment,

Agreed; Sean, can that patch still go into Emacs 31?

> but given that (gnus-icalendar-identities) always returns the value of
> user-full-name as the first element in the list, it may make sense to
> just treat the head and tail of the list differently because when the
> first value is a string it will never be regexp-quoted but all other
> string values will be.

Perhaps gnus-icalendar-identities is not the function we need.  It looks
to me like wherever this function is actually used, its return value is
always just searched to find the ATTENDEE corresponding to the user.
Seems like it would be better to just fold the logic of checking the
various IDs Gnus knows about directly into
gnus-icalendar-event--find-attendee, instead of passing this mishmash
down the call stack.  WDYT?

Best,
Richard