bug#81467: [PATCH] Make bookmark-jump work with other-window/frame/tab-prefix
martin rudalics via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <[email protected]>
| Newsgroups | gmane.emacs.bugs |
|---|---|
| Message-ID | <[email protected]> |
> Ideally, we need `advice-let` to detect whether the `display-buffer` > function was called from `bookmark-handle-bookmark`. > And then don't funcall `display-function` to display the same buffer > again. Unlike `cl-letf`, only `advice-let` would be able to call the > original function. Here is how its use could look: > > (defun bookmark--jump-via (bookmark-name-or-record display-function) > (let ((was-called nil)) > (advice-let ((display-buffer (:around (ofun &rest args) detect-call) > (apply ofun args) > (setq was-called t))) > ;; Some handlers call 'display-buffer'. > (bookmark-handle-bookmark bookmark-name-or-record)) > (unless was-called > (funcall display-function buf)))) Over my head. How would you describe that in a manual? What if 'display-buffer' to show another unrelated buffer is called in 'bookmark-handle-bookmark'? martin