bug#81467: [PATCH] Make bookmark-jump work with other-window/frame/tab-prefix

Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <[email protected]>
Newsgroups gmane.emacs.bugs
Message-ID <[email protected]>
Hi,

Juri Linkov <[email protected]> writes:

>> What if 'display-buffer' to show another unrelated buffer
>> is called in 'bookmark-handle-bookmark'?
>
> It's possible to check the buffer.  Also using the same trick
> as in 'display-buffer-override-next-command' that temporarily
> changes 'display-buffer-overriding-action', here is the patch
> that does the same, but uses the added action as a way to detect
> if 'display-buffer' was already called with the same buffer:

It doesn't make much sense for bookmark--jump-via to ignore the
DISPLAY-FUNCTION argument, no matter what the handler does, IMO.
The contract for bookmark handlers is that someone else (the caller,
not the handler) displays the bookmarked buffer; if the handler
nevertheless displays the bookmarked buffer (or any other buffer),
that's the handler's fault/responsibility.
I don't think bookmark.el should try to circumvent it.

For this specific bug report, I recommend just fixing the EWW handler.


Best,

Eshel
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.