bug#80555: [PATCH 0/3] markdown-ts-mode: setext levels, strikethrough, block quote continuations
Stéphane Marks <[email protected]> Mon, 13 Apr 2026 07:44:33 -0400
| Newsgroups | gmane.emacs.bugs |
|---|---|
| Message-ID | <CAN+1Hbq+AU+=Xi6DZSoLtSmTsQKQnxFjP-f8h7fxD3zRi6M3Og@mail.gmail.com> |
--000000000000488252064f5602f8 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Apr 13, 2026 at 7:31=E2=80=AFAM Eli Zaretskii <[email protected]> wrote: > > From: Rahul Martim Juliato <[email protected]> > > Cc: Eli Zaretskii <[email protected]>, [email protected], Yuan Fu > > <[email protected]>, [email protected], [email protected], > > [email protected] > > Date: Sun, 12 Apr 2026 23:33:44 -0300 > > > > St=C3=A9phane Marks <[email protected]> writes: > > > > > On Sun, Apr 12, 2026 at 7:10=E2=80=AFAM St=C3=A9phane Marks <shipmint= [email protected]> > wrote: > > > > > > On Sun, Apr 12, 2026 at 4:32=E2=80=AFAM Eli Zaretskii <[email protected]>= wrote: > > > > > > > Cc: Daniel Nouri <[email protected]>, [email protected], > > > > Juri Linkov <[email protected]> > > > > From: Yuan Fu <[email protected]> > > > > Date: Sun, 8 Mar 2026 23:02:36 -0700 > > > > > > > > > > > > > > > > > On Mar 7, 2026, at 1:55=E2=80=AFAM, Sean Whitton < > [email protected]> wrote: > > > > > > > > > > Daniel Nouri [06/Mar 4:08pm +01] wrote: > > > > >> Hello, > > > > >> > > > > >> This series improves fontification in markdown-ts-mode in three > small, > > > > >> independent changes. > > > > > > > > > > Thanks, adding Yuan and Juri for review. > > > > > > > > Thanks to you both! The patches look good to me, and they all have > nice commit messages :) It makes sense to remove the settext header > > > face. Better remove it now before anybody gets attached to it. It=E2= =80=99s > also kind of my fault. I should=E2=80=99ve caught it and make settext use= the same > face > > > as regular headers. > > > > > > > > Once Daniel=E2=80=99s paperwork is done, I=E2=80=99ll apply the pa= tches. > > > > > > Daniel, any news about your copyright-assignment paperwork? > > > > > > I missed this discussion as I'm guessing Rahul did. I think all > discussion should move to bug#80740 as it is a much more robust > implementation of > > > markdown-ts-mode and with many more faces which correctly represent > key Markdown entities. > > > > > > FYI, the email containing whatever patches were attached never got > through. I have a feeling a lot of messages were lost in the ether this > week. > > > > > > > Hi all, > > > > I was not aware of this thread. > > > > St=C3=A9phane and I have since submitted a comprehensive rework of > > markdown-ts-mode under bug#80740. > > > > It goes beyond fontification, covering broader CommonMark support, alon= g > > with some GFM features (including links, image previews, and editing > > features), and introduces a more consistent and extensible structure > > overall. It also addresses bug#80613, bug#80625, and bug#80690. > > > > The implementation is not compatible with this patch series, and > > applying both would lead to conflicts and duplication. > > > > Given this, I agree with St=C3=A9phane that discussion should move to > > bug#80740, which supersedes this series. > > Do the patches in bug#80740 provide all the functionality that was > proposed in the present discussion? If not, what would it take to add > the missing functionality on top of what's discussed in bug#80740? > > IOW, it's okay to move the discussion there, but let's not lose some > useful improvement as result of that. > Yes bug#80740 covers these. The bug#80555 OP is encouraged to test that patch and provide feedback there. --000000000000488252064f5602f8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr"><div class=3D"gmail_default" style=3D"fon= t-family:monospace"><span style=3D"font-family:Arial,Helvetica,sans-serif">= On Mon, Apr 13, 2026 at 7:31=E2=80=AFAM Eli Zaretskii <<a href=3D"mailto= :[email protected]">[email protected]</a>> wrote:</span></div></div><div class=3D"= gmail_quote gmail_quote_container"><blockquote class=3D"gmail_quote" style= =3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding= -left:1ex">> From: Rahul Martim Juliato <<a href=3D"mailto:rahuljulia= [email protected]" target=3D"_blank">[email protected]</a>><br> > Cc: Eli Zaretskii <<a href=3D"mailto:[email protected]" target=3D"_blank= ">[email protected]</a>>,=C2=A0 <a href=3D"mailto:[email protected]" tar= get=3D"_blank">[email protected]</a>,=C2=A0 Yuan Fu<br> >=C2=A0 <<a href=3D"mailto:[email protected]" target=3D"_blank">casou= [email protected]</a>>,=C2=A0 <a href=3D"mailto:[email protected]" target=3D"_b= lank">[email protected]</a>,=C2=A0 <a href=3D"mailto:[email protected]" t= arget=3D"_blank">[email protected]</a>,<br> >=C2=A0 =C2=A0<a href=3D"mailto:[email protected]" target=3D"_bla= nk">[email protected]</a><br> > Date: Sun, 12 Apr 2026 23:33:44 -0300<br> > <br> > St=C3=A9phane Marks <<a href=3D"mailto:[email protected]" target= =3D"_blank">[email protected]</a>> writes:<br> > <br> > > On Sun, Apr 12, 2026 at 7:10=E2=80=AFAM St=C3=A9phane Marks <<= a href=3D"mailto:[email protected]" target=3D"_blank">[email protected]= </a>> wrote:<br> > ><br> > >=C2=A0 On Sun, Apr 12, 2026 at 4:32=E2=80=AFAM Eli Zaretskii <<= a href=3D"mailto:[email protected]" target=3D"_blank">[email protected]</a>> wrote= :<br> > ><br> > >=C2=A0 > Cc: Daniel Nouri <<a href=3D"mailto:daniel.nouri@gm= ail.com" target=3D"_blank">[email protected]</a>>, <a href=3D"mailt= o:[email protected]" target=3D"_blank">[email protected]</a>,<br> > >=C2=A0 >=C2=A0 Juri Linkov <<a href=3D"mailto:[email protected]= t" target=3D"_blank">[email protected]</a>><br> > >=C2=A0 > From: Yuan Fu <<a href=3D"mailto:[email protected]"= target=3D"_blank">[email protected]</a>><br> > >=C2=A0 > Date: Sun, 8 Mar 2026 23:02:36 -0700<br> > >=C2=A0 > <br> > >=C2=A0 > <br> > >=C2=A0 > <br> > >=C2=A0 > > On Mar 7, 2026, at 1:55=E2=80=AFAM, Sean Whitton = <<a href=3D"mailto:[email protected]" target=3D"_blank">spwhitton= @spwhitton.name</a>> wrote:<br> > >=C2=A0 > > <br> > >=C2=A0 > > Daniel Nouri [06/Mar=C2=A0 4:08pm +01] wrote:<br> > >=C2=A0 > >> Hello,<br> > >=C2=A0 > >> <br> > >=C2=A0 > >> This series improves fontification in markdow= n-ts-mode in three small,<br> > >=C2=A0 > >> independent changes.<br> > >=C2=A0 > > <br> > >=C2=A0 > > Thanks, adding Yuan and Juri for review.<br> > >=C2=A0 > <br> > >=C2=A0 > Thanks to you both! The patches look good to me, and t= hey all have nice commit messages :) It makes sense to remove the settext h= eader<br> > >=C2=A0 face. Better remove it now before anybody gets attached to = it. It=E2=80=99s also kind of my fault. I should=E2=80=99ve caught it and m= ake settext use the same face<br> > >=C2=A0 as regular headers.<br> > >=C2=A0 > <br> > >=C2=A0 > Once Daniel=E2=80=99s paperwork is done, I=E2=80=99ll = apply the patches.<br> > ><br> > >=C2=A0 Daniel, any news about your copyright-assignment paperwork?= <br> > ><br> > >=C2=A0 I missed this discussion as I'm guessing Rahul did.=C2= =A0 I think all discussion should move to bug#80740 as it is a much more ro= bust implementation of<br> > >=C2=A0 markdown-ts-mode and with many more faces which correctly r= epresent key Markdown entities.<br> > ><br> > > FYI, the email containing whatever patches were attached never go= t through.=C2=A0 I have a feeling a lot of messages were lost in the ether = this week.<br> > ><br> > <br> > Hi all,<br> > <br> > I was not aware of this thread.<br> > <br> > St=C3=A9phane and I have since submitted a comprehensive rework of<br> > markdown-ts-mode under bug#80740.<br> > <br> > It goes beyond fontification, covering broader CommonMark support, alo= ng<br> > with some GFM features (including links, image previews, and editing<b= r> > features), and introduces a more consistent and extensible structure<b= r> > overall. It also addresses bug#80613, bug#80625, and bug#80690.<br> > <br> > The implementation is not compatible with this patch series, and<br> > applying both would lead to conflicts and duplication.<br> > <br> > Given this, I agree with St=C3=A9phane that discussion should move to<= br> > bug#80740, which supersedes this series.<br> <br> Do the patches in bug#80740 provide all the functionality that was<br> proposed in the present discussion?=C2=A0 If not, what would it take to add= <br> the missing functionality on top of what's discussed in bug#80740?<br> <br> IOW, it's okay to move the discussion there, but let's not lose som= e<br> useful improvement as result of that.<br></blockquote><div><br></div><div c= lass=3D"gmail_default" style=3D""><font face=3D"monospace">Yes bug#80740=C2= =A0covers these.=C2=A0 The bug#80555=C2=A0OP is encouraged to test that pat= ch and provide feedback there.</font></div></div></div> --000000000000488252064f5602f8--