bug#81552: [PATCH] Fix handling of spaces for webjump's Wikipedia query

Perry Fraser [05/Aug 10:33am -04] wrote:
> Sean Whitton <[email protected]> writes:
>
>> Perry Fraser [04/Aug  5:02pm -04] wrote:
>>> From 1a0e57c09514f1469ebf858e649d8ceb27477543 Mon Sep 17 00:00:00 2001
>>> From: Perry Fraser <[email protected]>
>>> Date: Tue, 4 Aug 2026 16:29:27 -0400
>>> Subject: [PATCH] Fix webjump's encoding of spaces for Wikipedia
>>>
>>> Wikipedia expects spaces to be encoded as underscores rather than
>>> pluses, so give it a site function that wraps
>>> `webjump-do-simple-query' and makes that replacement. Also adjust
>>> its URL to use Special:Search which will redirect to a search page
>>> if the query doesn't match an existing article.
>>
>> We prefer things like this to be in code comments instead of in the
>> commit message.
>
> Interesting—that definitely goes against my normal instinct. For
> example, the note about changing to using `Special:Search', it
> wouldn't make sense to leave that as a comment. In my mind that
> belongs in the commit message.

If it truly about why we had to *change* it rather than the content of
the code before or after, then it can go in the commit.

In this case using Special:Search at all seems like something worth
explaining in a comment.

-- 
Sean Whitton