bug#81406: 31.0.90; rotate-windows loses window balance when window-combination-resize is t

On Sun, 2 Aug 2026 at 17:43, martin rudalics <[email protected]> wrote:
>
>  > I think we need to add a error after lines 183-191
>  > Which would be like (unless (cdr winls) (user-error "Not enough
>  > windows to rotate."))
>
> Then what about the following scenario:
>
> (let* ((window1 (selected-window))
>         (window2 (split-window))
>         (window3 (split-window window2)))
>    (set-window-buffer window2 (get-buffer-create "*b2"))
>    (set-window-buffer window3 (get-buffer-create "*b3"))
>    (set-window-dedicated-p window1 t)
>    (y-or-n-p "Rotate? ")
>    (rotate-windows))
>
> Here it puts *b3* in the window that formerly showed *scratch*.
>  > Or we could make this a prefix argument. But in my opinion this would
>  > be overengineering, as the user can simply just un dedicate the window
>  > of their use case get's more complex
>
> AFAICT handling dedicated windows specially in 'rotate-windows' _is_
> over-engineering.  Note that people dedicate windows mostly to avoid that
> 'display-buffer' shows another buffer in them.  So please reconsider.

Ok I think it sounds more reasonable(as well as the fact I really
don't want to debug the above code haha) to remove dedicated window
handling in that case, maybe if someone requests it in the future we
can maybe look into it. I think this should be just as simple as
removing a couple of lines from the definition of winls to be:

(seq-filter #'window-live-p (flatten-list win-tree))

Also in the commit, can we also change the author email to my current
one instead of the one that is there (hosting your own email server is
more time consuming than expected)