bug#81223: [PATCH] Fix file-missing error during async native compilation
James Cherti <[email protected]> Fri, 7 Aug 2026 09:47:39 -0400
| Newsgroups | gmane.emacs.bugs |
|---|---|
| Message-ID | <[email protected]> |
Hello Sean and Phillip, Please don't make it difficult to contribute to Emacs. I would appreciate it if we focused on the core changes rather than nitpicking. The latest patch already includes comments that are clear enough and is ready to be merged. On 2026-08-07 06:45, Sean Whitton wrote: > James Cherti [06/Aug 7:20pm -04] wrote: >> Subject: [PATCH] Fix file-missing error during async native compilation (bug#81223) >> >> The async native compilation queue can sometimes retain stale jobs for >> files that no longer exist on disk (for example, when files are removed >> during a package upgrade or deletion). Attempting to resolve the target >> .eln filename for these missing files signals a file-missing error. > > Please remove this or move it into comments. We prefer not to have > extensive commentary in commit messages, see CONTRIBUTE. > >> * lisp/emacs-lisp/comp-run.el (comp--run-async-workers): Verify source >> files exist before attempting to resolve their .eln paths in the >> dispatch loop. In the process sentinel, wrap the compilation block in a >> condition-case to catch file-missing errors and prevent the async worker >> queue from stalling. > > Possibly this could be made shorter too, but it's less important. > -- James Cherti GitHub: https://github.com/jamescherti Website: https://www.jamescherti.com/