bug#81223: [PATCH] Fix file-missing error during async native compilation
James Cherti <[email protected]> Fri, 7 Aug 2026 17:47:01 -0400
| Newsgroups | gmane.emacs.bugs |
|---|---|
| Message-ID | <[email protected]> |
On 2026-08-07 14:25, Philip Kaludercic wrote: > James Cherti <[email protected]> writes: > >> Hello Sean and Phillip, >> >> Please don't make it difficult to contribute to Emacs. >> >> I would appreciate it if we focused on the core changes >> rather than nitpicking. >> >> The latest patch already includes comments that are clear >> enough and is ready to be merged. > > FWIW I just left a comment for you to know that whoever will merge this, > would eventually point out that you were missing a bug number reference, > and I wanted to save you the potential roundtrip. @Philip: Thanks Philip for clarifying that your comment was intended to be informational, rather than a condition for merging this patch. @Sean: I decline to make this change, as doing so would encourage counterproductive behavior within the community. The patch is ready to be merged. (Heavy nitpicking on small details, especially for simple patches, makes contributors hesitate before submitting future work.) >> On 2026-08-07 06:45, Sean Whitton wrote: >>> James Cherti [06/Aug 7:20pm -04] wrote: >>>> Subject: [PATCH] Fix file-missing error during async native compilation (bug#81223) >>>> >>>> The async native compilation queue can sometimes retain stale jobs for >>>> files that no longer exist on disk (for example, when files are removed >>>> during a package upgrade or deletion). Attempting to resolve the target >>>> .eln filename for these missing files signals a file-missing error. >>> Please remove this or move it into comments. We prefer not to have >>> extensive commentary in commit messages, see CONTRIBUTE. >>> >>>> * lisp/emacs-lisp/comp-run.el (comp--run-async-workers): Verify source >>>> files exist before attempting to resolve their .eln paths in the >>>> dispatch loop. In the process sentinel, wrap the compilation block in a >>>> condition-case to catch file-missing errors and prevent the async worker >>>> queue from stalling. >>> Possibly this could be made shorter too, but it's less important. >>> >> >> -- >> James Cherti >> GitHub: https://github.com/jamescherti >> Website: https://www.jamescherti.com/ > > > -- James Cherti GitHub: https://github.com/jamescherti Website: https://www.jamescherti.com/