bug#81537: 32.0.50; Fixing icomplete-in-buffer requiring users to advice-add

Eshel Yaron [07/Aug  3:29pm +02] wrote:
> Sean Whitton <[email protected]> writes:
>
>> Eshel Yaron [06/Aug  7:04am +02] wrote:
>>> So I'd say it currently seems that the completion-in-region-function API
>>> can/should be enough for icomplete-in-buffer.
>>
>> To be clear, I haven't given your patch any live testing, because I
>> don't think changes that invasive can be justified.
>
> Well, my patch affects only icomplete-in-buffer users, whereas the
> alternative you recently implemented touches code that virtually all
> users run.  The way I see it, using the existing API in icomplete.el
> is the less invasive approach: it confines the changes to where they
> belong.

Very fair point.

>> As I think that Icomplete logic in minibuffer.el is acceptable in this
>> case, I'm not going to work on this directly, but very happy to review
>> and discuss.  If you're not going to work on this imminently, though,
>> let's close the bug again.
>
> OK, feel free to close it.

Okay, will do, hope someone will come up with good semantics for a hook
so that we can replace mention of Icomplete in minibuffer.el at some
point.

-- 
Sean Whitton