bug#81561: 31.0.91; speedbar-window-mode creates stale idle timers

Daniel Mendler <[email protected]> writes:

> Ciao Vincenzo!
>
> Vincenzo Pupillo <[email protected]> writes:
>> Ciao, sorry for the delay—I'm on vacation. The attached patch should fix the 
>> bug. It's partly due to an incorrect condition in 'dframe-set-timer' that 
>> doesn't follow what's written in the comment. This fix also resolves an issue 
>> with 'speedbar-frame-mode,' which wasn't clearing the timer even when 
>> 'speedbar-buffer' was killed.
>>
>> @Daniel, can you please check to see if the patch fixes the problem?
>
> Yes, thank you! The patch fixes the problem. The stale timers are gone
> when the speedbar is closed.
>
> Eli, can you please apply this to emacs-31, since it fixes an issue,
> which has been newly introduced via the new speedbar-window-mode?

I spoke to soon. I am now observing these errors occasionally after
closing the speedbar, invoking M-x speedbar repeatedly.

DFRAME TIMER ERROR: (error "Selecting deleted buffer") [21 times]

After that there are still stale dframe-timer-fn in the timer list. So
it seems the fix is not complete.

> Daniel