bug#81589: 31.0.91; Regression: window-buffer-change-functions no longer firing on set-window-configuration
"J.D. Smith" <[email protected]>
| Newsgroups | gmane.emacs.bugs |
|---|---|
| Message-ID | <[email protected]> |
martin rudalics <[email protected]> writes: >> In the latest v31, upon using `set-window-configuration' (e.g. via >> `tab-bar-history-back') to change the buffer in a window, the >> `window-buffer-change-functions' are not run. Neither global nor >> buffer-local values of this hook are run, in contrast to earlier >> versions. >> >> I have verified that this is a recent regression caused by commit >> d6f7b2d99bd in bug#81097. With this commit, the hook does not run. >> Without it, it does. >> >> Reproducer for the buffer-local case: >> >> emacs -Q >> Eval: >> >> (add-hook 'window-buffer-change-functions >> (lambda (frame) >> (walk-windows >> (lambda (win) >> (message "W=%s WOB=%s" win (window-old-buffer win))) >> nil frame)) nil t) >> >> M-x tab-bar-history-mode >> C-x right ; *Message* showing, (<win 3 on *Messages*> *scratch*) >> M-x tab-bar-history-back ; *scratch* showing, but hook was not called > > I hopefully fixed that on the release branch. Please try again. Thanks martin, your fix in 73d959233e2 works fine here — both default and buffer-local hook values now run correctly on set-window-configuration. Appreciate your quick response. JD