bug#81581: [PATCH 1/1] Add a LESSP argument to 'seq-min' and 'seq-max'
Sean Whitton <[email protected]>
| Newsgroups | gmane.emacs.bugs |
|---|---|
| Message-ID | <[email protected]> |
Philip Kaludercic [09/Aug 4:29pm GMT] wrote: >> Code looks good, interesting approach with the eval-when-compile >> (I would have used a cl-loop since it doesn't seem like it's truly a >> reduction, but what you have is fine). > > Why isn't this a reduction? Just a defeasible aesthetic intuition. > Sean Whitton <[email protected]> writes: > >> Sean Whitton [09/Aug 11:50am +01] wrote: >>> Code looks good, interesting approach with the eval-when-compile >>> (I would have used a cl-loop since it doesn't seem like it's truly a >>> reduction, but what you have is fine). >> >> Well, a while loop, probably, given seq.el is preloaded. > > Hmm, but that would amount to just manually looping over the sequence > (seq-length seq) many times and comparing the current best element with > that in (seq-elt seq i)? Yes. -- Sean Whitton