bug#81510: 31.0.90; NS (macOS): clicking a disabled (:enable nil) tab-bar item crases Emacs

block 81521 by 81510
thanks

Eli Zaretskii [13/Aug  7:17am +03] wrote:
>> Date: Wed, 12 Aug 2026 21:05:30 +0100
>> From: Alan Third <[email protected]>
>> Cc: Sean Whitton <[email protected]>, [email protected],
>> 	[email protected], [email protected]
>>
>> On Wed, Aug 12, 2026 at 02:12:09PM +0300, Eli Zaretskii wrote:
>> > > Date: Tue, 11 Aug 2026 19:50:16 +0100
>> > > From: Alan Third <[email protected]>
>> > > Cc: Eli Zaretskii <[email protected]>, [email protected],
>> > > 	[email protected]
>> > >
>> > > On Tue, Aug 11, 2026 at 10:25:10AM +0100, Al Haji-Ali wrote:
>> > > >
>> > > > On 04/08/2026, Alan Third wrote:
>> > > > > If a NO_EVENT event is never required to go in any queue, we can get
>> > > > > away with the attached. This should prevent us from putting NO_EVENT's
>> > > > > into either queue from any of the event functions.
>> > > >
>> > > > I've tested this and it does indeed prevent the crash and I think it's
>> > > > the better solution.
>> > > >
>> > > > I am not sure if condition the XSETFRAME on NO_EVENT is correct since I
>> > > > don't quite understand why it's needed.
>> > >
>> > > We're just dropping the event, so it doesn't need the XSETFRAME call.
>> > >
>> > > I've pushed this change to master.
>> >
>> > Since this is a crash, should it be backported to the release branch?
>>
>> Probably, yes. I think the patch is pretty safe. Should I cherry pick it?
>
> I think so, yes.  Sean, WDYT?

I agree, please cherry-pick it there and then close the bug, Alan.

-- 
Sean Whitton