bug#68339: [patch] Set the IME window font to an appropriate size

dANiuu zHaO <[email protected]> writes:

> [PATCH 5] Set the IME window font to an appropriate size
>
> Added a check for face->font so that it can fall back to FRAME_FONT.
> If any issues are found during testing, please feel free to contact me.
>
> dANiuu zHaO <[email protected]> 于2026年8月7日周五 13:53写道：
>
>  Yes, it does need some time for people to test it. My copyright assignment paperwork has been signed, but I haven't heard back yet.
>
>  As for the code, I will set up `face->fallback` later. I honestly didn't expect `face->font` could return NULL.
>
>  Eli Zaretskii <[email protected]> 于2026年8月7日周五 13:45写道：
>
>  > From: dANiuu zHaO <[email protected]>
>  > Date: Fri, 7 Aug 2026 11:36:41 +0800
>  > Cc: Eason Huang <[email protected]>, [email protected]
>  > 
>  > @@ -6682,6 +6686,8 @@ w32_draw_window_cursor (struct window *w, struct glyph_row *glyph_row,
>  >           + WINDOW_HEADER_LINE_HEIGHT (w);
>  >         w32_system_caret_mode_height = WINDOW_MODE_LINE_HEIGHT (w);
>  >  
>  > +       w32_system_remap_font = face ? face->font : FRAME_FONT (f);
>
>  face->font can yield NULL in some rare cases, so there's another
>  face->fallback missing here, to use FRAME_FONT in that case as well.
>
>  Otherwise, I think we should wait for a while for people to test this
>  patch (and for your copyright-assignment paperwork), before we install
>  it.
>
>  Thanks.
>
>

Hello Eli and dANiuu,

I have tested the latest patch on my Windows machine with Windows 11.
It works very well, no crash anymore.


-- 
Eason Huang