bug#81533: c-ts-mode: Improved block comment indentation

Eli Zaretskii <[email protected]>
Newsgroups gmane.emacs.bugs
Message-ID <[email protected]>
> Date: Sat, 15 Aug 2026 21:59:40 +0200
> Cc: [email protected], [email protected], [email protected]
> From: Björn A. Lindqvist <[email protected]>
> 
> On 8/15/26 15:23, Eli Zaretskii wrote:
> > I was about to install this, but this patch breaks the c-ts-mode
> > tests:
> > 
> >    Test c-ts-mode-test-indentation backtrace:
> >      signal(ert-test-failed (("Mismatch in test \"Multiline Block Comment
> >      ert-fail(("Mismatch in test \"Multiline Block Comments 2 (bug#60270)
> >      ert-test--erts-test(((code lambda nil (c-ts-mode) (setq-local indent
> >      ert-test-erts-file("d:/gnu/git/emacs/trunk/test/lisp/progmodes/c-ts-
> >      #f(lambda () [t] (let* ((fn-0 #'treesit-ready-p) (args-1 (condition-
> >      #f(compiled-function () #<bytecode 0x1ea918ef364892c1>)()
> >      handler-bind-1(#f(compiled-function () #<bytecode 0x1ea918ef364892c1
> >      ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
> >      ert-run-test(#s(ert-test :name c-ts-mode-test-indentation :documenta
> >      ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
> >      ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil
> >      ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp))))
> >      ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco
> >      eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n
> >      command-line-1(("-L" ";." "-l" "ert" "--eval" "(setq treesit-extra-l
> >      command-line()
> >      normal-top-level()
> >    Test c-ts-mode-test-indentation condition:
> >        (ert-test-failed
> >         ("Mismatch in test \"Multiline Block Comments 2 (bug#60270)\", file d:/gnu/git
> >    /emacs/trunk/test/lisp/progmodes/c-ts-mode-resources/indent.erts"
> > 	"/*\n   some comment\n */\n" "/*\n  some comment\n */\n"))
> >       FAILED  2/4  c-ts-mode-test-indentation (0.207103 sec) at lisp/progmodes/c-ts-mode-tests.el:26
> > 
> > Could you please amend the code or the test to avoid the breakage, and
> > then resubmit?
> 
> Sure, attached a new patch wit the tests fixed.

Hmm... looks exactly like the previous patch to me.  Are you sure you
sent the right patch?

> > Also, these changes are close to the limit of what we are able to
> > accept from you without the copyright-assignment agreement.  If you
> > agree to start the assignment paperwork at this time, I will send you
> > the form to fill and the instructions to go with it.
> 
> Sure, go ahead!

Form sent off-list.
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.