bug#81537: 32.0.50; Fixing icomplete-in-buffer requiring users to advice-add

Juri Linkov [14/Aug  8:01pm +03] wrote:
>>>  (defcustom icomplete-in-buffer nil
>>>    "If non-nil, use Icomplete when completing in buffers other than minibuffer.
>>>  This affects commands like `completion-in-region', but not commands
>>> -that use their own completions setup."
>>> -  :type 'boolean)
>>> +that use their own completions setup.  If the value is `both',
>>> +display both in-buffer completions and the *Completions* buffer."
>>> +  :type '(choice (const :tag "Disable" nil)
>>> +                 (const :tag "Enable" t)
>>> +                 (const :tag "Enable with popup window" both)))
>>
>> Let's use 'with-completions-popup' instead of 'both'.
>
> Done in a new patch.
>
>>> -(defun completion--icomplete-in-buffer-p ()
>>> -  (eq (bound-and-true-p icomplete--in-region-buffer) (current-buffer)))
>>> +(defvar completion-list-inhibit-functions nil
>>> +  "Abnormal hook for inhibiting display of the *Completions* buffer.
>>> +If any of these functions returns non-nil, it inhibits the display
>>> +of *Completions*.  This is useful mostly for `icomplete-mode' with
>>> +non-nil `icomplete-in-buffer' to not display both Icomplete in-buffer
>>> +completions and the *Completions* buffer.")
>>
>> I think the last sentence of this docstring should be deleted or made
>> into a code comment instead.
>
> Done too in the next patch:

LGTM, thanks.

-- 
Sean Whitton