bug#81638: 32.0.50; flyspell-prog-text-faces type and semantics

Eli Zaretskii [18/Aug  3:06pm +03] wrote:
>> From: Sean Whitton <[email protected]>
>> Cc: [email protected]
>> Date: Tue, 18 Aug 2026 11:12:35 +0100
>> 
>> Eli Zaretskii [17/Aug  2:09pm +03] wrote:
>> > And if all of the above is not enough, and you still insist, I could
>> > agree to adding nil to the valid values (but then please suggest a
>> > suitable :tag), but allowing any symbol is IMO too dangerous,
>> > especially as we use cl-flet there.  Next we will hear from someone
>> > reporting a vulnerability in Emacs.
>> 
>> It's not a safe local variable value, though, it's just a customisation
>> option.  Allowing the user to input any symbol there seems okay to me.
>
> There's the value :all of enable-local-variables, yes?
>
> Anyway, I'm surprised you agree to go with such inelegant solutions.
> This use case is clearly outside of flyspell-prog-mode's design space,
> so adding another Flyspell variant that does fit these use cases
> sounds much cleaner to me.  Hacks and kludges are okay as local
> solutions, but here we are asked to officially embrace such a kludge.
> And that's even before we talk about discoverability, which basically
> will be nonexistent for others who'd want to do the same.

I didn't mean to suggest that I think we should go with that solution, I
was just commenting on the safety/security aspect of the proposed patch.

It seems like we should take a step back here.  Doing this by matching
on faces does not seem like a principled approach; as Stefan said, it's
a quick hack.

It seems like we could use a whole new mode taking a different approach.

-- 
Sean Whitton