Re: Branch_5_35 is missing defun [email protected]

Hello, John.

On Thu, Mar 16, 2023 at 09:35:20 -0400, John Ciolfi wrote:
> Hi

> I tried using Branch_5_35 by downloading and building with Emacs 27 on
> Debian 11:

> https://sourceforge.net/code-snapshots/hg/c/cc/cc-mode/cc-mode/cc-mode-cc-mode-4f6405bb784e024f501d1e48251eeec23424b830.zip

> I received:

>   Debugger entered--Lisp error: (void-function c-update-new-id)

> and grep'ing the code, I see there's no defun for c-update-new-id:

>   cc-mode.el:2143:   (c-update-new-id end)

Yes.  Sorry about this.  It slipped in last May in an enhancement mainly
for the default branch of the repository.  Since the obtrusive call is
in c-after-change (an after-change function), it can simply be removed.  

I've corrected the Branch_5_35 branch in the repository, and I'm
enclosing the patch, should you not want to download again.

Just as a matter of interest, there's basically nothing happening any
more on Branch_5_35.  I keep meaning to release version 5.36, but
haven't got round to it yet.

I would recommend using the default branch (which gets tested on Emacs
25.3, to make sure it works with older Emacsen).  This is basically the
same version as on the current Emacs master branch (at
savannah.gnu.org), but has no dependencies on the current Emacs.

Anyhow, here's the (one-line) patch:



diff -r 4f6405bb784e -r 6e668595af4a cc-mode.el
--- a/cc-mode.el	Fri Oct 28 11:57:50 2022 +0000
+++ b/cc-mode.el	Sun Mar 19 15:00:17 2023 +0000
@@ -2140,7 +2140,6 @@
 						 c->-as-paren-syntax)
 	       (c-clear-char-property-with-value beg end 'syntax-table nil)))
 
-	   (c-update-new-id end)
 	   (c-trim-found-types beg end old-len) ; maybe we don't need all
 					; of these.
 	   (c-invalidate-sws-region-after beg end old-len)


> Thanks
> John

-- 
Alan Mackenzie (Nuremberg, Germany).