Re: void variable "property" on XEmacs in c-put-char-properties

Hello, Richard.

On Fri, Sep 01, 2023 at 11:20:26 +0100, Richard Hopkins wrote:
> Hi Alan,

> The following tweak to `c-put-char-properties' macro fixes a void
> variable error for "property" on XEmacs and it's now used in the same
> way as earlier in the XEmacs path, as well as the GNU path.

> diff -r 1a76fcde9cab cc-defs.el
> --- a/cc-defs.el        Thu Aug 03 11:21:46 2023 +0000
> +++ b/cc-defs.el        Fri Sep 01 11:12:45 2023 +0100
> @@ -1313,7 +1313,7 @@
>                              (delete-extent ext))
>                            nil -from- -to- nil nil ',property)
>               (set-extent-properties (make-extent -from- -to-)
> -                                   (cons property
> +                                   (cons ',property
>                                            (cons ,value
>                                                  '(start-open t
>                                                               end-open 
> t)))))

> Does this look right to you?

It does, but there were more serious problems with the XEmacs version of
c-put-char-properties which I have now fixed and committed to CC Mode,
Emacs (savannah), and XEmacs (heptapod).

The make-extent call, making a single extent covering several
characters, was simply misconceived, and gave rise to lots of errors in
the test suite.  Replacing it with put-text-property fixed these.

So, thanks for the suggestion for the patch, but sorry I won't be using
it.

> Best,
> Richard

-- 
Alan Mackenzie (Nuremberg, Germany).