Re: [PATCH] Java assert keyword

--===============0133214699120859639==
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha512; protocol="application/pgp-signature"

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Hi Alan and Eli,

Eli, I've CC-ed you regarding paperwork for contributing to Emacs
(namely CC mode, but I'd prefer to sign off on as much as possible so
that I don't have to print even more agreements ;-) ).

Relevant patches are below.

Alan Mackenzie <[email protected]> writes:

> Hello, Arsen.
>
> At last!  (Apologies again.)
>
> On Sat, Oct 05, 2024 at 15:42:53 +0200, Arsen Arsenovi=C4=87 wrote:
>> Hi Alan!
>
>> I've, regrettably, been writing Java lately and I noticed CC-mode
>> doesn't recognize asserts.  So I added it, hopefully correctly.
>
> CC Mode has fallen quite some way behind on Java.  I've mainly been
> trying to keep up to date with C++ (C is less of a problem, and the
> other languages are mostly fairly static).  I underestimated the amount
> of effort CC Mode would need when I took it on (around 20 years ago).

Heh, underestimation is frequent in software.  I've done that many
times.

>> I haven't used Mercurial before, so forgive me if I've done something
>> wrong, but I've pushed my patch on Sourcehut, visible here:
>> https://hg.sr.ht/~arsen/cc-mode/rev/15bcae1c6ae0f68c75791f9239879af71c4f=
237c
>
> Mercurial is not such a big deal.  It's (much) easier to learn to use
> than git.  I doubt you've done anything wrong with the patch.  :-)

Sure, but I know git inside and out, and I don't even know Mercurial
out!  ;)

>> ... and fetchable via: https://hg.sr.ht/~arsen/cc-mode
>
>> PS: It is somewhat unclear where to send patches to CC-mode, so I've
>> sent them to you and CC'd cc-mode-help.  Hopefully that is right.
>
> The place to send patches for CC Mode is [email protected].

Ah, alright - I was worried that redirects to Debbugs automatically, so
I figured here is better.

> But first things first - have you signed copyright assignment papers
> for Emacs?

I haven't had the need.  I figured these patches were below the
significance threshold so I just sent them without bothering anyone.

> That bit of bureaucracy is (unfortunately) a prerequisite for
> contributing to Emacs (or any other part of the GNU project).

Not any other - some of the toolchain projects happily accept patches
without it for the most part.  I've still assigned copyright for the
stuff I work on, but it's not a requirement.

> If not, could I ask you to do that, please?  I've forgotten the exact
> procedure, but I can ask Eli Zaretskii (chief Emacs maintainer), who
> knows it well.

I have not.

Eli, to save you some time digging, here are the patches in question:
https://hg.sr.ht/~arsen/cc-mode/rev/15bcae1c6ae0f68c75791f9239879af71c4f237c
https://hg.sr.ht/~arsen/cc-mode/rev/ce95a9f9caa050602c107f61dbe933e31338674e

Do these need copyright assignment?  How should I go about it?  TIA

> If/when so, I'll have a look at your patch, and (almost certainly)
> incorporate it.

Thanks :-)

> Thanks for taking the trouble to get into CC Mode.  The code is not
> always as simple and straightforward as I would like it to be, and I've
> made quite a few mistakes over the years.

As have we all!

> Would you consider doubling the size of the CC Mode team by joining it,
> mainly to concentrate on Java?

Note that I mainly write C++ by trade - software I work on are written
in it, and I prefer writing it.

My contact with Java nowadays is mostly academic (as in, related to
university work, mainly because it's a lingua franca among students),
but I've been writing it for a long time and know too much about it..

So, I'm afraid I can't guarantee that I'll be up-to-date with new
developments in Java.

That said - I'd love to help with CC-mode, however much I can in the
small amount of time I have free, with the little Elisp knowledge I
have.

I cannot promise I'll be of too much help, though; I am quite busy, and
not an expert in Emacs-y code by any means.

If I am to continue fixing Java-related hiccups, though, I'd need to
figure out records next, I think.  I've also noticed lack of support for
multiline strings.  Is there documentation on how the CC-mode parser
works?  If not, I'll try digging a little next weekend.

> Before saying yes, please bear in mind that CC Mode is being
> superseded by the Tree Sitter modes (like c-ts-mode and c++-ts-mode)
> and its future as a prime set of Emacs mode is somewhat in doubt.

This surprises me.

To be clear, I'm not surprised by tree-sitter superseding a _parser_,
but a whole mode is not a just a parser, nor just a highlighting engine.

I primarily don't use the -ts- mode (as someone who is a fan of
Tree-sitter) because their implementations of other parts of what
constitutes a mode are not as good (the indentation engines are worse,
handling of comments is worse, probably some other bits).

I expected that, eventually, the "old-style" modes would start using
tree-sitter information to do indentation.

Have a lovely day!
=2D-=20
Arsen Arsenovi=C4=87

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iOYEARYKAI4WIQT+4rPRE/wAoxYtYGFSwpQwHqLEkwUCZx57Y18UgAAAAAAuAChp
c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0RkVF
MkIzRDExM0ZDMDBBMzE2MkQ2MDYxNTJDMjk0MzAxRUEyQzQ5MxAcYXJzZW5AYWFy
c2VuLm1lAAoJEFLClDAeosST/wgBAMGyja8d5Bq6zdndux60kFvs0lp/y3gX88ea
rDH/zq69AQCBSeNiQx1JJzoIwTPb6lEX/oo+DpcMf4MvEmlNLnz2DQ==
=n+yK
-----END PGP SIGNATURE-----
--=-=-=--


--===============0133214699120859639==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline


--===============0133214699120859639==--