Re: Error on entering el files in emacs git repo

Eric M. Ludlam writes:

> Yes, I see the new version number.  I think it used to be just "emacs", 
> but now it says "GNU Emacs".
>
> The whole version parse function looks a bit broken / confused.  It is 
> going to need a revamp.  There is a grep call whose output is never used. :(
>
> I'm going to guess a patch like this untested one helps.  (against the 
> ede-ldf branch, or hand merge.)  Tweak it and let me know how it goes, 
> if it helps I can commit it.
>
> Thanks
> Eric
>
> === modified file 'lisp/cedet/ede/emacs.el'
> *** lisp/cedet/ede/emacs.el	2014-06-04 01:44:11 +0000
> --- lisp/cedet/ede/emacs.el	2014-07-12 01:48:38 +0000
> ***************
> *** 91,97 ****
>           (t
>    	(insert-file-contents configure_ac)
>    	(goto-char (point-min))
> ! 	(re-search-forward "AC_INIT(emacs,\\s-*\\([0-9.]+\\)\\s-*)")
>    	(setq ver (match-string 1))
>    	)
>           )
> --- 91,97 ----
>           (t
>    	(insert-file-contents configure_ac)
>    	(goto-char (point-min))
> ! 	(re-search-forward "AC_INIT(\\(?:GNU 
> \\)[Ee]macs,\\s-*\\([0-9.]+\\)\\s-*)")
>    	(setq ver (match-string 1))
>    	)
>           )
>

Hi Eric,

The above regexp is almost correct. The correct one (as I tested it) is:

(re-search-forward "AC_INIT(\\(?:GNU \\)[Ee]macs,\\s-*\\([0-9.]+\\),\\s-*.*)")

Since the actual AC_INIT is:

AC_INIT(GNU Emacs, 24.4.50, [email protected])

The regexp in your patch only handles up to Emacs version but not the email address, so it will fail.

Regards,

Tu.
	

> On 07/07/2014 01:36 AM, Tu Do wrote:
>> Hi Erics,
>>
>> Is this the version number you mentioned:
>> http://repo.or.cz/w/emacs.git/blob/9d555d4f0b471c3ad2a517b40e1a68392cc47c0e:/configure.ac#l24
>> ?
>>
>> Tu.
>>
>>
>> On Fri, Jul 4, 2014 at 5:52 AM, Eric M. Ludlam <[email protected]
>> <mailto:[email protected]>> wrote:
>>
>>     On 07/03/2014 09:32 AM, Tu Do wrote:
>>
>>         Hi Eric,
>>
>>         I tried to open an .el file in cloned Emacs repo at
>>         http://repo.or.cz/w/emacs.git
>>
>>         However, I could not and got this error:
>>
>>         ede-emacs-version: Search failed:
>>         "AC_INIT(emacs,\\s-*\\([0-9.]+__\\)\\s-*)"
>>
>>
>>     It looks like the Emacs version number format has changed.  Again.
>>
>>     I looked in configure.ac <http://configure.ac>, but I don't know how
>>     that version number is indicated now.  If you can find it, we can
>>     updated the version checker to look for it.
>>
>>
>>         I am using your experimental ede-test CEDET. It's been great so
>>         far with
>>         the EDE enhancement on C/C++ buffers. I have a suggestion: it
>>         would be
>>         more convenient, if CEDET can leverage EDE integration with VCS. For
>>         example, instead of manually specifying include path, is it
>>         possible to
>>         make Semantic search for that file using the new EDE, and cached in
>>         SemanticDB for later use?
>>
>>
>>     Yes, that is a good idea.  There are a lot of different ways to
>>     store an include path in a project area, and nice things a VCS can
>>     do to help find things.
>>
>>     My intention is to get this first big change merged back into CEDET.
>>       A different thread pointed out that some of the old relationships
>>     between projects has caused code duplication.  I think that project
>>     would be next.  Once simplified it will be easier to add general
>>     support for things like a VCS providing data generally across
>>     project types.
>>
>>     Eric
>>
>>

-- 
Sent with my mu4e

------------------------------------------------------------------------------
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds