Re: [PATCH] Extended PHP support

Steven Rémot writes:
> I have been working for some weeks on improving PHP support in
> CEDET. So far, I have added:
>
> - Parsing of namespaces declarations
> - Parsing of aliases declarations
> - Parsing of namespaced names
> - Parsing of optional type hints for function arguments
> - Proper parsing of class fields and constants
> - completion of tags declared in the same file (it also includes the
> special values $this, self and static)
>
> It still lacks a lot of functionnalities, but I think I got enough
> improvements to give you this version.
>
> I don't really know what is the preferred format for substantial
> contributions, so I sent witht this mail an archive containing the
> commit history generated by "git format-patch". It seems to be
> compatible with bazaar.

Sorry for the late reply.

I don't really know PHP, so I'm afraid I can't comment on these patches
in detail. I've skimmed over them and they look good to me, so I'd have
no problem with committing these patches into the repository. Eric, what
do you think?

-David

------------------------------------------------------------------------------
Want excitement?
Manually upgrade your production database.
When you want reliability, choose Perforce
Perforce version control. Predictably reliable.
http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk