Re: Typecache does not contain include tags created at expansion

Sorry for not responding sooner.  Busy times.  ;)

On 01/24/2015 06:35 AM, Steven Rémot wrote:
> OK, I think I got it : I did not override `semantic-find-tags-included'
> for php-mode, and this was required to find include tags defined inside
> a namespace. When "semantic/bovine/c" is loaded, it overrides
> `semantic-find-tags-included' for c-mode. As php-mode derives from
> c-mode this solves the issue.

I'm glad you found the solution.  I wouldn't have guessed that php 
inherited from C.  There are probably several other overrides that php 
shouldn't be inheriting from C.

> Now, I wonder what is the cleanest way to solve the issue: I can define
> `semantic-find-tags-included' in php-mode, and that will avoid a
> dependency to "semantic/bovine/c". However, the code will be exactly the
> same, so this leads to duplication. On the other hand, I can still load
> "semantic/bovine/c" to share code and avoid duplication, but this leads
> to one more dependency.

It is probably better to duplicate, because php is bound to require a 
few more tweaks that are different from C as you improve support.  I 
don't know enough about php to guess what though.

> In my opinion sharing code is not a bad idea, so I would rather include
> "semantic/bovine/c" in "contrib/wisent-php". What do you think about it ?

Both are fine by me, and it will reduce unreliable behavior for any 
other C overrides that might do odd things in php.

> 2015-01-21 23:01 GMT+01:00 Steven Rémot <[email protected]


>>         In your output, I notice that you tags are saved in :members
>>         in an order different than the text of the parsed buffer.  Is
>>         that a cut and paste error in your email, or is that real?  I
>>         also noticed the output excludes an positional information,
>>         either in [ start end ] or overlay form.  Is that on purpose?
>         I think the reverse order in :members is not done on purpose.
>         Would it be better to put them on the right order ? Also, I
>         stripped position information to ease reading in the mail, but
>         if you need it I can give you the full result of bovinate.

I only pointed out the missing position information in case there were 
bugs in your parser preventing them from being there.

When you see [123 456] positioning information in tags dumped by 
'bovinate' it indicates a bug in your override for (or you don't have an 
override for) semantic-tag-components.

>
>         I can't find anything about the "using" tag in the manual. I
>         already saw it in the code for C++ support, is this tag specific
>         to this language ?

It is specific to C++, but happens to be known in the core scope 
handling code.  As such, it should probably get propagated up to be with 
the other top tags like function, etc.

Eric

------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________
Cedet-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/cedet-devel