Re: Two minor bugfixes

On 02/16/2015 03:47 PM, Martin Stein wrote:
> Hi Eric,
>
>>> Second bug:
>>> File: 0001-Save-global-variable-wisent-lookahead-before-calling.patch
>>>
[...]
>> This is a great find.  Thanks.  I've installed it here and it passes the
>> test suites.  Was there an example that exposed this that is short you
>> can share?  Can the bug be exposed using some existing language?  It
>> would be nice if I could add a test for this.
[...]
>
> You might add this example once the fortran wisent grammar is included
> in cedet. For some reason I cannot produce this with python or some

Thanks.  That sounds like the best bet.

> BTW: Is there any reason not to declare a wisent-parser class, with
> slots for all those variables. All those indirections via global
> variables (like with wisent-lexer-function) looks crazy. Clearly one
> reason would be that its much work for not much gain.

I considered this, and discussed it with David Ponce (who wrote wisent) 
but EIEIO was not up for the task back then.  Today it would probably be 
good, especially with the changes Stefan is doing optimizing method 
calls.  At this point, everything works so as you say, not much gain.

Eric

------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=190641631&iu=/4140/ostg.clktrk