Re: commit changes to Emacs core?
Eric Ludlam <[email protected]> Wed, 26 Aug 2015 22:46:09 -0400
| Newsgroups | gmane.emacs.cedet |
|---|---|
| Message-ID | <CACXnnKOgRh+3RSkCZ3uLhpBvx1uKjhquPaHFkpxHNWZ0VcqvDw@mail.gmail.com> |
The current CEDET git supports back to Emacs 24. I think once the next merge happens we'll stick to Emacs 25. As you point out, your patch needed an Emacs patch, so the intended new feature wasn't testable by me so I didn't submit it. David's notion to push that upstream is a good one. Many of our tests are still old school and need to be converted to ert still. Eric On Aug 26, 2015 1:11 PM, "Stephen Leake" <[email protected]> wrote: > Eric Ludlam <[email protected]> writes: > > > As an added bonus, the change didn't function when I tried it out with an > > older Emacs 24 so I didn't commit. > > What is the oldest Emacs version supported? > > Describing mode-local-overloads in *Help* does rely on a change in Emacs > 25. In Emacs 24, it should show the default function. > > So I'm not clear what you mean by "didn't function". But I haven't tried > it yet in Emacs 24. > > > On Aug 26, 2015 5:37 AM, "David Engster" <[email protected]> wrote: > > > >> Until then, it is best to fix things in Emacs proper, > > Ok, I'll do that. > > The patch for elisp--xref-find-definitions to support mode-local > overrides includes tests in emacs/master/test/automated/elisp-mode.el. > > I considered adding those tests to the CEDET test suite instead, but it > doesn't look like that's set up to use ert. Let me know if you think that > would be better, and I can try harder. > > -- > -- Stephe > ------------------------------------------------------------------------------ _______________________________________________ Cedet-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/cedet-devel