Secondary Overlays Bugfix

--Apple-Mail=_1A55B746-AEF3-4774-A9BC-5433381DF29B
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

Hi All,

This is patch 2/4.

It's a fix for overlays from the decorate package.
It looks like the interface to `semantic-tag-create-secondary-overlay'
changed somewhere along the line. When tags are linked to the buffer,
the overlays are removed and then re-added using the unlink/link hooks.

`semantic=E2=80=94tag-link-secondary-overlays=E2=80=99 tried to fetch =
the list of secondary
overlays on a tag, remove them from the tag object and then re add each =
of
them in turn. However, it passed the tag and the overlay to the
`semantic-tag-create-secondary-overlay=E2=80=99 which should instead =
accept the tag
and a link hook to run once the secondary overlay has been created.

This produces several error messages similar to the following
=E2=80=9CError wrong type argument: symbolp #<overlay =E2=80=A6"

I=E2=80=99m unsure whether by making my change I=E2=80=99ve broken the =
intended way for this
to work =E2=80=94 i.e. that there are multiple overlays which ought to =
be added one after
the other =E2=80=94 but it does look like it wasn=E2=80=99t working =
altogether without this fix.

Kind regards,

Edward Steere


--Apple-Mail=_1A55B746-AEF3-4774-A9BC-5433381DF29B
Content-Disposition: attachment;
	filename=0002-Fixed-an-error-in-decorate-for-secondary-overlays.patch
Content-Type: application/octet-stream;
	name="0002-Fixed-an-error-in-decorate-for-secondary-overlays.patch"
Content-Transfer-Encoding: quoted-printable

=46rom=208106d88c3fb4ae3b26a55b521193d0960583cec5=20Mon=20Sep=2017=20=
00:00:00=202001=0AFrom:=20Edward=20Steere=20<[email protected]>=0A=
Date:=20Fri,=2025=20Mar=202016=2012:30:44=20+0200=0ASubject:=20[PATCH=20=
2/4]=20Fixed=20an=20error=20in=20decorate=20for=20secondary=20overlays.=0A=
=0AIt=20looks=20like=20the=20function=20=
semantic-tag-create-secondary-overlay=20might=0Ahave=20once=20taken=20a=20=
tag=20as=20well=20as=20the=20secondary=20overlay=20it=20should=20update,=0A=
however=20in=20the=20current=20version=20of=20CEDET=20it=20accepts=20a=20=
tag=20and=20the=20hook=20to=0Arun=20after=20adding=20the=20secondary=20=
overlay.=20I'm=20not=20sure=20if=20we're=20now=0Amissing=20some=20=
overlays=20with=20my=20fix,=20but=20it=20at=20least=20conforms=20to=20=
the=20API=20of=0Athe=20function.=0A---=0A=20=
lisp/cedet/semantic/decorate.el=20|=2010=20+++++-----=0A=201=20file=20=
changed,=205=20insertions(+),=205=20deletions(-)=0A=0Adiff=20--git=20=
a/lisp/cedet/semantic/decorate.el=20b/lisp/cedet/semantic/decorate.el=0A=
index=205bd683f..f0ffe22=20100644=0A---=20=
a/lisp/cedet/semantic/decorate.el=0A+++=20=
b/lisp/cedet/semantic/decorate.el=0A@@=20-242,11=20+242,11=20@@=20from=20=
them=20in=20TAG."=0A=20=20=20(let=20((ol=20=
(semantic-tag-secondary-overlays=20tag)))=0A=20=20=20=20=20;;=20Wipe=20=
out=20old=20values.=0A=20=20=20=20=20(semantic--tag-put-property=20tag=20=
'secondary-overlays=20nil)=0A-=20=20=20=20;;=20Run=20all=20the=20link=20=
hooks.=0A-=20=20=20=20(while=20ol=0A-=20=20=20=20=20=20=
(semantic-tag-create-secondary-overlay=20tag=20(car=20ol))=0A-=20=20=20=20=
=20=20(setq=20ol=20(cdr=20ol)))=0A-=20=20=20=20))=0A+=20=20=20=20;;=20=
Previously=20it=20looks=20like=20the=20signature=20of=0A+=20=20=20=20;;=20=
`semantic-tag-create-secondary-overlay'=20accepted=20the=20secondary=0A+=20=
=20=20=20;;=20overlay=20to=20be=20updated.=20Now,=20it=20doesn't.=20It=20=
takes=20the=20link=20hook=0A+=20=20=20=20;;=20to=20run,=20so=20instead=20=
we=20simply=20call=20it=20with=20tag.=0A+=20=20=20=20=
(semantic-tag-create-secondary-overlay=20tag)))=0A=20=0A=20;;;=20=
Secondary=20Overlay=20Uses=0A=20;;=0A--=20=0A2.5.4=20(Apple=20Git-61)=0A=0A=

--Apple-Mail=_1A55B746-AEF3-4774-A9BC-5433381DF29B
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140
--Apple-Mail=_1A55B746-AEF3-4774-A9BC-5433381DF29B
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Cedet-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/cedet-devel

--Apple-Mail=_1A55B746-AEF3-4774-A9BC-5433381DF29B--