Re: ECB Window management bug(Customize/EShell/VC-Log...)

<[email protected]>
Newsgroups gmane.emacs.code-browser
Message-ID <[email protected]>
Hi,

Just tested with current ECB beta (2.33), cedet from CVS and Emacs 22.3.1 (the latest official release)... Neither customze-option nor eshell fails - all is working fine...

Unfortunatelly i have no Emacs 23.X here so i can not test with that Emacs-version.....

Also, i do not understand, why you patch (set-buffer (ad-get-arg 0)) should be necessary in the advice of pop-to-buffer because there is already a call (select-window (display-buffer....) and select-window should make the buffer current...

Can you run your tests with Emacs 22.3.1 too so we can see if there are differences in the behavior...

Any thoughts?

Ciao,
Klaus


-----Ursprüngliche Nachricht-----
Von: [email protected] [mailto:[email protected]] 
Gesendet: Montag, 16. März 2009 09:56
An: [email protected]; [email protected]
Betreff: Re: [ECB-list] ECB Window management bug(Customize/EShell/VC-Log...)

Sorry for the late answer, but I'm currently preparing a new release of ECB which contains a lot of bug-fixes ...

I never could reproduce this problem so please send me the following information:
- have you tried it with a vanilla Emacs, means no other packages except ECB (and cedet) activated?

Or with other words: Please send me your settings of Emacs/ECB which causes this problem to occur...

Thanks a lot!
Klaus

-----Ursprüngliche Nachricht-----
Von: finalpatch [mailto:[email protected]]
Gesendet: Montag, 5. Januar 2009 06:54
An: [email protected]
Betreff: Re: [ECB-list] ECB Window management bug(Customize/EShell/VC-Log...)

finalpatch <[email protected]> writes:

> finalpatch <[email protected]> writes:
>
>> Hi,
>>
>> I found this bug particularly annoying. Steps to reproduce:
>>
>> Start Emacs (emacs shows the scratch buffer) M-x ecb-activate (ecb 
>> windows created around the scratch window) M-x customize (emacs 
>> switches to an EMPTY Customize buffer, the customize stuff is 
>> inserted to the scratch buffer rather than the customize buffer)
>>
>> The same thing happens for Eshell as well(and VC-log when you hit C-x 
>> v v on a version controled file to commit it). With ECB active, 
>> running Eshell will cause the command prompt being insert into the 
>> buffer you were editing.
>
> Sorry, forgot to mention that my Emacs version is
>
> GNU Emacs 23.0.60.1 (i386-mingw-nt6.0.6001) of 2008-12-31
>
> And I use the latest CVS ECB.

After digging into the code a bit, I've come up with a solution. The following patch should fix the problem described in the orignial post. This is due to Emacs's 'pop-to-buffer' implies selecting that buffer, but ECB's adviced version does do this, which causes all subsequent commands get sent to the wrong buffer.

--- ecb-layout.el.~1.258.~	Thu May  8 22:03:44 2008
+++ ecb-layout.el	Mon Jan  5 16:48:43 2009
@@ -1707,6 +1707,7 @@
                                    (ad-get-arg 0) (ad-get-arg 1))
            (select-window (display-buffer (ad-get-arg 0)
                                           (ad-get-arg 1)))
+           (switch-to-buffer (ad-get-arg 0))
            (if (ad-get-arg 2)
                ;; not the best solution but for now....
                (bury-buffer (ad-get-arg 0))))


--
finalpatch


------------------------------------------------------------------------------
_______________________________________________
Ecb-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ecb-list

------------------------------------------------------------------------------
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are powering Web 2.0 with engaging, cross-platform capabilities. Quickly and easily build your RIAs with Flex Builder, the Eclipse(TM)based development software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com _______________________________________________
Ecb-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ecb-list

------------------------------------------------------------------------------
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.