Re: Contributing xc.el to ELPA

On Friday, July 17th, 2026 at 2:53 PM, Stefan Monnier <[email protected]> wrote:
> As for comments on your code, see the untested attached patch whose most
> important change is to avoid the use of a shell (and associated need to
> quote arguments).

I've reviewed these patches and they look good. A couple questions:

## shell usage
I see you replaced `call-process-shell-command' with `call-process' in one place, which is fine, but you left `async-shell-command' in another place. Are you hoping I'll find a way to remove that usage of a shell? Many common tasks invoke `git' or `ssh' which may prompt interactively for input, so having a shell in those cases is handy.

## treemacs-treelib availability
You noted that `(require 'treemacs-treelib)' will fail to compile if it's not installed. I use three functions and three macros from treemacs-treelib, and xc-treelib.el is only relevant or useful for users with treemacs installed. Would you recommend I should move that functionality out into another package entirely, or is there some pattern I can use to prevent it from being compiled on systems without treemacs available?

Thank you again!
Ryan