Re: [gnu] externals/corfu 44b92683837: corfu-popupinfo: window-inside-pixel-edges takes tab line into account on 31

Stefan Monnier <[email protected]>
Newsgroups gmane.emacs.devel
Message-ID <[email protected]>
>         (below (>= cfy (+ lh (cadr (window-inside-pixel-edges))
> -                         (window-tab-line-height)
> +                         (static-if (< emacs-major-version 31)
> +                             (window-tab-line-height) 0)
>                           (or (cdr (posn-x-y (posn-at-point (point)))) 0))))

As is often the case, this will misbehave if you compile on Emacs-NN and
then run it in Emacs-MM.  IOW, strictly speaking it should be an `if`
rather than a `static-if`.

Maybe we should offer an option to "optimize for the current Emacs
version" where the compiler treats `emacs-major-version` as
a compile-time constant.


=== Stefan
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.