Re: eglot-tests fail for emacs-31 branch
Michael Albinus <[email protected]>
| Newsgroups | gmane.emacs.devel |
|---|---|
| Message-ID | <[email protected]> |
João Távora <[email protected]> writes: > Hi Michael, Hi Joao, > Well, I don't know how you draw the line between an incomplete > and broken environment, but here this seems very clearly the latter > to me: a typescript-language-server installation without typescript > is manifestly useless. I don't know what happened to it, but my > local EMBA copy (cloned some months ago following the instructions > you pointed me to) has this: > > root@59a84580aeb9:/checkout# apt search typescript > node-tslib/now 2.4.1-1 all [installed,local] > Implementation of tslib for javascript > > node-typescript/now 4.9.5+ds1-2 all [installed,local] > TypeScript is a language for application scale JavaScript development > > In it, the javascript Eglot tests pass without a problem. So something > regressed in this environment somehow, no? > >> > Or or delete typescript-language-server entirely (it's not very useful >> > without typescript, is it?). The test will be skipped. >> >> Thanks. > > Hope you're not misunderstanding here. This test will be skipped > once you (or someone) deletes the defective typescript-language-server > installation. We will lose a signal, but that's life. I don't have > plans for changes to eglot-tests: I think the code is fine as is. On emba, the eglot tests run in a clean Debian trixie container. Then, the following software is installed: --8<---------------cut here---------------start------------->8--- FROM debian:trixie AS emacs-eglot # This mimics emacs-base. RUN apt-get update && \ apt-get install -y --no-install-recommends -o=Dpkg::Use-Pty=0 \ libc-dev gcc g++ make autoconf automake libncurses-dev gnutls-dev \ libxml2-dev libdbus-1-dev libacl1-dev acl git man-db texinfo gdb \ && rm -rf /var/lib/apt/lists/* # Install clangd, tsserver, rust-analyzer. RUN apt-get update && \ apt-get install -y --no-install-recommends -o=Dpkg::Use-Pty=0 \ clangd npm node-typescript rust-analyzer cargo \ && rm -rf /var/lib/apt/lists/* RUN npm install -g typescript-language-server typescript RUN npm install -g vscode-json-languageserver --8<---------------cut here---------------end--------------->8--- See test/infra/Dockerfile.emba. This hasn't changed for more than a year. You can try to reproduce with the local emba environment; see admin/notes/emba. > João Best regards, Michael.