Re: eglot-tests fail for emacs-31 branch

João Távora <[email protected]> writes:

> Hi again Michael,

Hi João,

>> RUN npm install -g typescript-language-server typescript
>> RUN npm install -g vscode-json-languageserver
>>
>> See test/infra/Dockerfile.emba.
>>
>> This hasn't changed for more than a year. You can try to reproduce with the local
>> emba environment; see admin/notes/emba.
>
> There is still a misunderstanding.  I _didn't_ write those lines
>
>     npm install -g typescript-language-server typescript
>
> someone else did.  I don't know when they were added, but I presume they
> were added well before the current state of things, because this person
> must have had the very same eglot-tests.el tests passing in mind, and
> they did pass or the change wouldn't have been committed.

That's simple to answer, "git blame' ('C-x v g') tells us:

--8<---------------cut here---------------start------------->8---
f1766fd2b35b (Michael Albinus     2025-06-08  71) # Install clangd, tsserver, rust-analyzer.
f1766fd2b35b (Michael Albinus     2025-06-08  72) RUN apt-get update && \
f1766fd2b35b (Michael Albinus     2025-06-08  73)     apt-get install -y --no-install-recommends -o=Dpkg::Use-Pty=0 \
13a4cd5ed1ed (Michael Albinus     2025-06-08  74)       clangd npm node-typescript rust-analyzer cargo \
5ae0c1673245 (Michael Albinus     2023-04-06  75)     && rm -rf /var/lib/apt/lists/*
e2ff4dbf3db5 (Michael Albinus     2023-03-25  76)
13a4cd5ed1ed (Michael Albinus     2025-06-08  77) RUN npm install -g typescript-language-server typescript
13a4cd5ed1ed (Michael Albinus     2025-06-08  78) RUN npm install -g vscode-json-languageserver
--8<---------------cut here---------------end--------------->8---

> In fact these
> tests _do_ pass in my local emba environment, which I setup about 2
> months ago to debug a related issue.

I've set up the local emba environment just now. Here I get the same two
eglot-tests errors as described initially. So I recommend you to throw
away the emacs-eglot docker image, and to set up the local emba
environment, again.

> So, logically, whatever happened recently cannot be attributed to
> changes in code to code eglot-tests.el because there were none.

Agreed.

> For me, it seems much more likely that the 'npm install -g' is aiming at
> moving target: likely the "typescript-language-server" package now has
> different requirements which somehow don't play well with Debian Trixie.
> So whoever is the npm connoisseur around these parts should try to "pin"
> those installations to a known good version.

If you speak about me: I'm not a connaisseur of npm, typescript, or
typescript-language-server. However, pinning a given package version is
not the solution. On emba, we try to run tests in a Debian environment
an Emacs user will see. If this doesn't work, we must fix it, or
document what to do.

> João

Best regards, Michael.