Re: master e4df903f6b5 2/2: ; Fix last change

Stefan Monnier <[email protected]> writes:

>>>>     * lisp/net/tramp.el (with-tramp-progress-reporter):
>>>>     Deactivate `progress-reporter-echo-area' when calling
>>>>     `progress-reporter-done'.  We call `tramp-message' instead.
>>> [...]
>>>> +	 (when (and tm pr)
>>>> +	   (cancel-timer tm)
>>>> +	   (cl-letf (((symbol-function #'progress-reporter-echo-area)
>>>> +		      #'ignore))
>>>> +	     (progress-reporter-done pr)))
>>> Yuck.
>> Could you, pls, be more verbose?
>
> I'm just saying that I find
>
>     	   (cl-letf (((symbol-function #'progress-reporter-echo-area)
>     		      #'ignore))
>
> to be an ugly hack (like most other "letf symbol-function").

I tend to agree. Do you have a better idea to suppress a message in the
*Messages* buffer when calling progress-reporter-done?

> === Stefan

Best regards, Michael.