Re: master 1d91d9b717d: project-vc-dir: Use truenames

On Thu, Jul 23, 2026, 16:15 Sean Whitton <[email protected]> wrote:

> João Távora [15/Jul  1:09am +01] wrote:
> > I've just tried your patch.  I didn't give it much testing, but it seems
> > to work exactly like I think it should.  I.e. C-x v d RET when
> > visiting any file in a symlinked repo seems to behave exactly like
> > C-x  p v.  I guess that's because dir defaults to 'vc-root-dir's value,
> > which is also good.
> >
> > I thought your earlier reply about vc-responsible-backend meant
> > that if I gave it a subdir it would revert to following the link, which
> > would again seem like a mistake to me.  But I see that even if
> > I give it a subdir, vc-responsible-backend still returns 'Git.
>
> I read the code at one point and was convinced that it wouldn't do what
> you want, but if you and Dmitry are now happy with its state, that's
> great.
>


Indeed, when reading it it appears to do something different, but I've
tried it and it does the right thing. Seems it almost never follows the
link (which is good in my view). I don't quite understand the conditions
under which it does. Maybe the fact that it fooled two programmers already
justifies a comment?

João