Re: eglot-tests fail for emacs-31 branch

João Távora <[email protected]> Tue, 28 Jul 2026 13:23:33 +0100
Newsgroups gmane.emacs.devel
Message-ID <CALDnm506_2shoprhgVCFGmFoMJ-XmPH7LO7yu=kq1BeaEA0Jmw@mail.gmail.com>
On Tue, Jul 28, 2026, 07:46 Michael Albinus <[email protected]> wrote:

> João Távora <[email protected]> writes:
>
> Hi João,
>
> >     What do you mean with "configure ... correctly"? There is absolute
> >     no
> >     information about which versions of typescript-language-server and
> >     vscode-json-languageserver must be used.
> >
> > Because there is no such information anywhere in the planet or need
> > for it. It's probably not even a question of versions at all. Eglot
> > works with any server that speaks LSP.
>
> Finally, I could fix it. See commit 5e3f68c669c in the emacs-31 branch.
> eglot-tests.el pass now on emba in the emacs-31 branch:
>
> --8<---------------cut here---------------start------------->8---
> SUMMARY OF TEST RESULTS
> -----------------------
> Files examined: 1
> Ran 60 tests, 48 results as expected, 0 unexpected, 12 skipped
> --8<---------------cut here---------------end--------------->8---
>
> > João
> >
> > PS: Trust me Michael, pin the versions :)
>
> That wasn't the problem.
>

I described a perfectly workable solution, not the problem :) IMO the root
problem wasn't worthy of investigation at all, but you seem to have thought
otherwise and solved it by deleting code, which is definitely very elegant.
I can only applaud and thank you.

João

PS: I would still pin the version though, as this has taught us that
tomorrow's npm update du jour might bite with another unexpected failure.

>