Re: emacs-31 74ec15e7684: ; Fix 'package--save-selected-packages' edge case (Bug#81091)

Philip Kaludercic [05/Aug  7:18pm GMT] wrote:
> Sean Whitton <[email protected]> writes:
>
>> Philip Kaludercic [02/Aug  7:45am -04] wrote:
>>> branch: emacs-31
>>> commit 74ec15e76847f4269d98aa83e1d43437bf307ca8
>>> Author: Philip Kaludercic <[email protected]>
>>> Commit: Philip Kaludercic <[email protected]>
>>>
>>>     ; Fix 'package--save-selected-packages' edge case (Bug#81091)
>>>
>>>     * lisp/emacs-lisp/package.el (package--save-selected-packages-1):
>>>     Add new function to just save the current value of
>>>     'package-selected-packages'.
>>>     (package--save-selected-packages): Do not add the function
>>>     itself to 'after-init-hook' during init-time, to avoid
>>>     distinguishing between between function calls wheren the
>>>     function is invoked without any argument by the hook or with a
>>>     single nil argument.
>>> ---
>>>  lisp/emacs-lisp/package.el | 23 +++++++++++++++++------
>>>  1 file changed, 17 insertions(+), 6 deletions(-)
>>
>> Please don't prepend commits like this with a semicolon, this is a
>> significant change.
>
> Sorry about that, in my eyes this was not a significant change, just a
> minor refactoring to address an edge-case.

I know what you mean, but you added a new function, and we want it to be
easy to trace back when that happened.

-- 
Sean Whitton