Re: master d423017cae1: * lisp/vc/vc-dir.el (vc-dir-headers): Try a hints separator line.
Dmitry Gutov <[email protected]> Fri, 7 Aug 2026 04:32:23 +0300
| Newsgroups | gmane.emacs.devel |
|---|---|
| Message-ID | <[email protected]> |
Hi Sean,
On 07/07/2026 13:11, Sean Whitton wrote:
> (vc-call-backend backend 'dir-extra-hints)
> - "\n")))
> + "\n" (make-separator-line) "\n")))
> (concat
FWIW, personally it seems to look better if I delete both surrounding
newlines - more compact, no loss in clarity.
It might also be nice to see the initial point position on the first
line under the separator. That could emphasize continuity with the
previous interface - that the hints are sort of a separate UI area.
WDYT?
diff --git a/lisp/vc/vc-dir.el b/lisp/vc/vc-dir.el
index e71e91e3c0a..2a25dc81a2b 100644
--- a/lisp/vc/vc-dir.el
+++ b/lisp/vc/vc-dir.el
@@ -1659,7 +1659,7 @@ vc-dir-headers
"(\\[vc-dir-hide-up-to-date]) Hide up-to-date"
"\n"
(vc-call-backend backend 'dir-extra-hints)
- "\n" (make-separator-line) "\n")))
+ (make-separator-line))))
(concat
(and vc-dir-show-key-binding-hints vc-dir--key-binding-hints)
(propertize "VC backend : " 'face 'vc-dir-header)
@@ -1827,6 +1827,8 @@ vc-dir-refresh
;; Bzr has serious locking problems, so setup the headers first
(this is
;; mostly synchronous) rather than doing it while dir-status is
running.
(vc-dir--set-header def-dir 'reset-footer)
+ (when vc-dir-show-key-binding-hints
+ (goto-char (1+ (length vc-dir--key-binding-hints))))
(let ((buffer (current-buffer)))
(with-current-buffer vc-dir-process-buffer
(setq default-directory def-dir)