Re: master 94646751192: compile.el: Fix last change

Arsen Arsenović <[email protected]> Tue, 18 Aug 2026 23:05:37 +0200
Newsgroups	gmane.emacs.devel
Message-ID	<[email protected]>
Stefan Monnier <[email protected]> writes:

>>     * lisp/progmodes/compile.el
>>     (compilation-error-regexp-alist-alist): ?\N{BULLET} cannot be used
>>     during bootstrap.
>
> Hmm... why is this code loaded during bootstrap?

If it helps, I do have the full build error saved (ellipsis replace a
long path to a tempdir):

  Loading .../work/emacs/lisp/progmodes/elisp-mode.el (source)...

  Error: error ("Eager macro-expansion failure: (file-missing \"Cannot open load file\" \"No such file or directory\" \"charprop\")")
    signal(error ("Eager macro-expansion failure: (file-missing \"Cannot open load file\" \"No such file or directory\" \"charprop\")"))
    error("Eager macro-expansion failure: %S" (file-missing "Cannot open load file" "No such file or directory" "charprop"))
    (condition-case err (let ((macroexp--pending-eager-loads (cons load-file-name macroexp--pending-eager-loads))) (if full-p (macroexpand--all-toplevel form) (macroexpand form))) ((debug error) (error "Eager macro-expansion failure: %S" err) form))
    (cond ((eq 'skip (car macroexp--pending-eager-loads)) form) ((and load-file-name (member load-file-name macroexp--pending-eager-loads)) (let* ((bt (delq nil (mapcar #'macroexp--trim-backtrace-frame (macroexp--backtrace)))) (elem (list 'load (file-name-nondirectory load-file-name))) (tail (member elem (cdr (member elem bt))))) (if tail (setcdr tail (list '…))) (if (eq (car-safe (car bt)) 'macroexpand-all) (setq bt (cdr bt))) (if macroexp--debug-eager (debug 'eager-macroexp-cycle) (error "Eager macro-expansion skipped due to cycle:\n  %s" (mapconcat #'prin1-to-string (nreverse bt) " => "))) (setq macroexp--pending-eager-loads (cons 'skip macroexp--pending-eager-loads)) form)) (t (condition-case err (let ((macroexp--pending-eager-loads (cons load-file-name macroexp--pending-eager-loads))) (if full-p (macroexpand--all-toplevel form) (macroexpand form))) ((debug error) (error "Eager macro-expansion failure: %S" err) form))))
    internal-macroexpand-for-load((defalias 'elisp-flymake-byte-compile #'(lambda (report-fn &rest _args) "A Flymake backend for elisp byte compilation.\nSpawn an Emacs process that byte-compiles a file representing the\ncurrent buffer state and calls REPORT-FN when done." (unless (trusted-content-p) (message "Disabling elisp-flymake-byte-compile in %s (untrusted content)" (buffer-name)) (user-error "Disabling elisp-flymake-byte-compile in %s (untrusted content)" (buffer-name))) (when elisp-flymake--byte-compile-process (when (process-live-p elisp-flymake--byte-compile-process) (kill-process elisp-flymake--byte-compile-process))) (let ((temp-file (make-temp-file "elisp-flymake-byte-compile")) (source-buffer (current-buffer)) (coding-system-for-write 'utf-8-unix) (coding-system-for-read 'utf-8)) (save-restriction (widen) (write-region (point-min) (point-max) temp-file nil 'nomessage)) (let* ((output-buffer (generate-new-buffer " *elisp-flymake-byte-compile*")) (warning-suppression-opt (and (derived-mode-p 'lisp-interaction-mode) '("--eval" "(setq bytecomp--inhibit-lexical-cookie-warning t)")))) (setq elisp-flymake--byte-compile-process (make-process :name "elisp-flymake-byte-compile" :buffer output-buffer :command `(,(elisp-flymake-byte-compile--executable) "-Q" "--batch" ,@(mapcan (lambda (path) (list "-L" path)) elisp-flymake-byte-compile-load-path) ,@warning-suppression-opt "-f" "elisp-flymake--batch-compile-for-flymake" ,temp-file) :connection-type 'pipe :sentinel (lambda (proc _event) (unless (process-live-p proc) (unwind-protect (cond ((not (and (buffer-live-p source-buffer) (eq proc (with-current-buffer source-buffer elisp-flymake--byte-compile-process)))) (flymake-log :warning "byte-compile process %s obsolete" proc)) ((zerop (process-exit-status proc)) (elisp-flymake--byte-compile-done report-fn source-buffer output-buffer)) (t (funcall report-fn :panic :explanation (format "byte-compile process %s died" proc)))) (ignore-errors (delete-file temp-file)) (kill-buffer output-buffer)))) :stderr " *stderr of elisp-flymake-byte-compile*" :noquery t)))))) t)
    eval-buffer(#<buffer  *load*> nil ".../work/emacs/lisp/progmodes/elisp-mode.el" nil t)
    (if eval-function (funcall eval-function buffer (if dump-mode file fullname)) (eval-buffer buffer nil (if dump-mode file fullname) nil t))
    (let ((read-symbol-shorthands shorthands)) (if eval-function (funcall eval-function buffer (if dump-mode file fullname)) (eval-buffer buffer nil (if dump-mode file fullname) nil t)))
    (let ((load-true-file-name fullname) (load-file-name fullname) (set-auto-coding-for-load t) (inhibit-file-name-operation nil) shorthands) (with-current-buffer buffer (set-buffer-multibyte t) (let (deactivate-mark) (insert-file-contents fullname)) (setq shorthands (and hack-read-symbol-shorthands-function (funcall hack-read-symbol-shorthands-function))) (if (and enable-multibyte-characters (or (eq (coding-system-type last-coding-system-used) 'raw-text))) (set-buffer-multibyte nil)) (set-buffer-modified-p nil)) (let ((read-symbol-shorthands shorthands)) (if eval-function (funcall eval-function buffer (if dump-mode file fullname)) (eval-buffer buffer nil (if dump-mode file fullname) nil t))))
    (unwind-protect (let ((load-true-file-name fullname) (load-file-name fullname) (set-auto-coding-for-load t) (inhibit-file-name-operation nil) shorthands) (with-current-buffer buffer (set-buffer-multibyte t) (let (deactivate-mark) (insert-file-contents fullname)) (setq shorthands (and hack-read-symbol-shorthands-function (funcall hack-read-symbol-shorthands-function))) (if (and enable-multibyte-characters (or (eq (coding-system-type last-coding-system-used) 'raw-text))) (set-buffer-multibyte nil)) (set-buffer-modified-p nil)) (let ((read-symbol-shorthands shorthands)) (if eval-function (funcall eval-function buffer (if dump-mode file fullname)) (eval-buffer buffer nil (if dump-mode file fullname) nil t)))) (let (kill-buffer-hook kill-buffer-query-functions) (kill-buffer buffer)))
    (let ((buffer (generate-new-buffer " *load*")) (load-in-progress t) (source (string-suffix-p ".el" fullname))) (unless nomessage (if source (message "Loading %s (source)..." file) (message "Loading %s..." file))) (when purify-flag (push file preloaded-file-list)) (unwind-protect (let ((load-true-file-name fullname) (load-file-name fullname) (set-auto-coding-for-load t) (inhibit-file-name-operation nil) shorthands) (with-current-buffer buffer (set-buffer-multibyte t) (let (deactivate-mark) (insert-file-contents fullname)) (setq shorthands (and hack-read-symbol-shorthands-function (funcall hack-read-symbol-shorthands-function))) (if (and enable-multibyte-characters (or (eq (coding-system-type last-coding-system-used) 'raw-text))) (set-buffer-multibyte nil)) (set-buffer-modified-p nil)) (let ((read-symbol-shorthands shorthands)) (if eval-function (funcall eval-function buffer (if dump-mode file fullname)) (eval-buffer buffer nil (if dump-mode file fullname) nil t)))) (let (kill-buffer-hook kill-buffer-query-functions) (kill-buffer buffer))) (do-after-load-evaluation fullname) (unless (or nomessage noninteractive) (if source (message "Loading %s (source)...done" file) (message "Loading %s...done" file))) t)
    (if (null (file-readable-p fullname)) (and (null noerror) (signal 'file-error (list "Cannot open load file" file))) (let ((buffer (generate-new-buffer " *load*")) (load-in-progress t) (source (string-suffix-p ".el" fullname))) (unless nomessage (if source (message "Loading %s (source)..." file) (message "Loading %s..." file))) (when purify-flag (push file preloaded-file-list)) (unwind-protect (let ((load-true-file-name fullname) (load-file-name fullname) (set-auto-coding-for-load t) (inhibit-file-name-operation nil) shorthands) (with-current-buffer buffer (set-buffer-multibyte t) (let (deactivate-mark) (insert-file-contents fullname)) (setq shorthands (and hack-read-symbol-shorthands-function (funcall hack-read-symbol-shorthands-function))) (if (and enable-multibyte-characters (or (eq (coding-system-type last-coding-system-used) 'raw-text))) (set-buffer-multibyte nil)) (set-buffer-modified-p nil)) (let ((read-symbol-shorthands shorthands)) (if eval-function (funcall eval-function buffer (if dump-mode file fullname)) (eval-buffer buffer nil (if dump-mode file fullname) nil t)))) (let (kill-buffer-hook kill-buffer-query-functions) (kill-buffer buffer))) (do-after-load-evaluation fullname) (unless (or nomessage noninteractive) (if source (message "Loading %s (source)...done" file) (message "Loading %s...done" file))) t))
    load-with-code-conversion(".../work/emacs/lisp/progmodes/elisp-mode.el" ".../work/emacs/lisp/progmodes/elisp-mode.el" nil nil)
    load("progmodes/elisp-mode")
    load("loadup.el")

It seems that I got lucky when rebasing my patch, in that charprop
survived in my build directory despite the build system being rebuilt.
-- 
Arsen Arsenović
signature.asc (application/pgp-signature, 418 B)