Re: master d423017cae1: * lisp/vc/vc-dir.el (vc-dir-headers): Try a hints separator line.
Sean Whitton <[email protected]>
| Newsgroups | gmane.emacs.devel |
|---|---|
| Message-ID | <[email protected]> |
Dmitry Gutov [18/Aug 4:56pm +03] wrote: > On 18/08/2026 12:53, Sean Whitton wrote: >> Dmitry Gutov [16/Aug 2:38am +03] wrote: >>> But how about this one? strike-through goes right through the middle. >>> Not sure why Lars chose underline originally - this seems to work fine >>> on all the terminal emulators I've tested, and where it doesn't (tty), >>> neither does underline. >> >> This looks great in my terminal but I feel the graphical display is a >> bit too cramped -- could we tweak it further? > I think the appropriate amount of spacing depends on the user's habit, > and the GUI often has smaller margins. > > So this element looks cramped on GUI after spending time in the terminal > and the terminal looks too spacey still after using the GUI version. > > I think that's ultimately fine because on the GUI at least the user can > choose between the shapes by customizing the face 'separator-line'. SGTM. Please install. > Personally, I would just choose a lighter color for the line, but the > spacing feels fine. Just like we don't have a large margin at the bottom > of menu-bar or the top of the mode-line. > > It would be nice to review the different uses of the separator-line for > consistency, though. And maybe start using it in Log-Edit too. I agree, it would be good to consider using it there too. -- Sean Whitton